ByteStreamBuildEventArtifactUploader: skip reading metadata for files that won't be uploaded #20575
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note
draft because I'm not yet sure about the implementation
54% of samples in a profile I took of our build included
readPathMetadata()
as far as I can tell, path metadata is only needed for files that are going to be uploaded to the CAS. for builds that use minimal remote uploads, this results in a lot of extra unneeded
stat
s.this makes a fully cached remote build (cold local) of a large subset of our monorepo 3x faster. I am not totally sure why given that (I think) this function is only used by the bes-uploader thread, but the working theory is that this allows BEP events to be processed more quickly, which keeps the
eventQueue
small and reducing memory usagetested with Bazel 6.4.0. have not tested this change because our monorepo is not compatible with Bazel 7.x yet.