Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[7.0.0] Give WORKSPACE toolchains and platforms precedence over non-root mo… #20430

Merged
merged 1 commit into from
Dec 4, 2023
Merged

[7.0.0] Give WORKSPACE toolchains and platforms precedence over non-root mo… #20430

merged 1 commit into from
Dec 4, 2023

Conversation

iancha1992
Copy link
Member

@iancha1992 iancha1992 commented Dec 4, 2023 •
edited
Loading

…dules

RELNOTES[INC]: Toolchains and execution platforms are now registered in the following order with --enable_bzlmod:

  1. root module's module file
  2. WORKSPACE or WORKSPACE.bzlmod
  3. non-root modules' module files
  4. default toolchains registered by Bazel (does not apply with WORKSPACE.bzlmod or execution platforms)

Fixes #20354

Closes #20407.

Commit 96b3612

PiperOrigin-RevId: 587826082
Change-Id: Ia98da6ef07b2fbf589ef369d986af2323af6f72a

@fmeum @Wyverald @iancha1992
Give WORKSPACE toolchains and platforms precedence over non-root mo…
12af3be 
…dules

RELNOTES[INC]: Toolchains and execution platforms are now registered in the following order with `--enable_bzlmod`:
1. root module's module file
2. `WORKSPACE` or `WORKSPACE.bzlmod`
3. non-root modules' module files
4. default toolchains registered by Bazel (does not apply with `WORKSPACE.bzlmod` or execution platforms)

Fixes bazelbuild#20354

Closes bazelbuild#20407.

Co-authored-by: Xudong Yang <[email protected]>
PiperOrigin-RevId: 587826082
Change-Id: Ia98da6ef07b2fbf589ef369d986af2323af6f72a
@iancha1992 iancha1992 added team-ExternalDeps External dependency handling, remote repositiories, WORKSPACE file. area-Bzlmod Bzlmod-specific PRs, issues, and feature requests awaiting-review PR is awaiting review from an assigned reviewer labels Dec 4, 2023
@iancha1992 iancha1992 requested review from katre and Wyverald December 4, 2023 21:49
@iancha1992 iancha1992 requested a review from a team as a code owner December 4, 2023 21:49
@iancha1992 iancha1992 enabled auto-merge (squash) December 4, 2023 21:49
@github-actions github-actions bot added team-Configurability platforms, toolchains, cquery, select(), config transitions team-Documentation Documentation improvements that cannot be directly linked to other team labels and removed team-ExternalDeps External dependency handling, remote repositiories, WORKSPACE file. labels Dec 4, 2023
@iancha1992 iancha1992 removed the team-Documentation Documentation improvements that cannot be directly linked to other team labels label Dec 4, 2023
@iancha1992 iancha1992 mentioned this pull request Dec 4, 2023
Closed
@keertk keertk added the team-ExternalDeps External dependency handling, remote repositiories, WORKSPACE file. label Dec 4, 2023
@iancha1992 iancha1992 merged commit d2dbad3 into bazelbuild:release-7.0.0 Dec 4, 2023
2 checks passed
@github-actions github-actions bot removed the awaiting-review PR is awaiting review from an assigned reviewer label Dec 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Wyverald Wyverald Wyverald approved these changes

@katre katre Awaiting requested review from katre

Assignees
No one assigned
Labels
area-Bzlmod Bzlmod-specific PRs, issues, and feature requests team-Configurability platforms, toolchains, cquery, select(), config transitions team-ExternalDeps External dependency handling, remote repositiories, WORKSPACE file.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@iancha1992 @Wyverald @keertk @fmeum