-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mark gcc-<version> as gcc
instead of compiler
in Unix CC toolchain
#20350
Mark gcc-<version> as gcc
instead of compiler
in Unix CC toolchain
#20350
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for taking this on! Just a few drive-by comments, this will have to be reviewed by a team member.
You can run bazel run //src/test/tools/bzlmod:update_default_lock_file
and commit the result to address the CI failures.
fe56c07
to
de64050
Compare
Thank you for the initial gcc-marking, as well as having a look and explaining the lock-file updating! I had a look at a few random passing PRs and didn't see any lock-file updates, so I figured I just had the worst of luck. The drive-by comments are very helpful. :) |
Previously only gcc-binaries named exactly `gcc` were marked as `gcc`, with the others being marked as `compiler`. Fixes bazelbuild#17794
de64050
to
650d26b
Compare
@comius I can't update labels here, but this is awaiting-review again. |
@bazel-io fork 7.1.0 |
Fixes bazelbuild#17794 I was looking at writing a test for this, but not sure how you'd like me to go about that. Hard-code a gcc, e.g. `gcc-11`, or search the `$PATH` for a `gcc-<version>`? Closes bazelbuild#20350. PiperOrigin-RevId: 604543138 Change-Id: I71ebbac77e4e32ebc5d99ec4a81415727af12cbc
…toolchain (#21224) Fixes #17794 I was looking at writing a test for this, but not sure how you'd like me to go about that. Hard-code a gcc, e.g. `gcc-11`, or search the `$PATH` for a `gcc-<version>`? Closes #20350. Commit 8877183 PiperOrigin-RevId: 604543138 Change-Id: I71ebbac77e4e32ebc5d99ec4a81415727af12cbc
Fixes #17794
I was looking at writing a test for this, but not sure how you'd like me to go about that. Hard-code a gcc, e.g.
gcc-11
, or search the$PATH
for agcc-<version>
?