[JSON Trace Profile] Add tid to counter series
#20300
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The JSON trace profile includes counter for data such as action count, CPU usage, memory usage. The code for writing the events to include these was refactored in bazelbuild@a03674e As part of that change the events written no longer include a `tid` (thread ID). However, each event in the JSON trace profile is expected to include a `tid`, as documented in https://docs.google.com/document/d/1CvAClvFfyA5R-PhYUmn5OOQtYMH4h6I0nSsKchNAySU/preview#heading=h.uxpopqvbjezh This change ensures the counter series events again have a `tid`, using the current thread's ID. This is consistent with the behavior that was present before the refactor. In response to bazelbuild#18548 (comment)
github-actions
bot
added
team-Performance
|
@meisterT Here's a suggested patch for #18548 (comment) |
|
Adding some people for visibility. It would be good to get this into 7 (because it fixes a regression). |
tjgq
approved these changes
Nov 27, 2023
|
@bazel-io fork 7.0.0 |
keertk
added
awaiting-PR-merge
github-actions
bot
removed
the
awaiting-PR-merge
bazel-io
pushed a commit
to bazel-io/bazel
that referenced
this pull request
Nov 27, 2023
The JSON trace profile includes counter for data such as action count, CPU usage, memory usage. The code for writing the events to include these was refactored in bazelbuild@a03674e As part of that change the events written no longer include a `tid` (thread ID). However, each event in the JSON trace profile is expected to include a `tid`, as documented in https://docs.google.com/document/d/1CvAClvFfyA5R-PhYUmn5OOQtYMH4h6I0nSsKchNAySU/preview#heading=h.uxpopqvbjezh This change ensures the counter series events again have a `tid`, using the current thread's ID. This is consistent with the behavior that was present before the refactor. In response to bazelbuild#18548 (comment) Fixes EngFlow/bazel_invocation_analyzer#113 Closes bazelbuild#20300. PiperOrigin-RevId: 585636103 Change-Id: I2aa1ff1e656324410d120ff5b6071028b0a5dce3
keertk
pushed a commit
that referenced
this pull request
Nov 27, 2023
The JSON trace profile includes counter for data such as action count, CPU usage, memory usage. The code for writing the events to include these was refactored in a03674e As part of that change the events written no longer include a `tid` (thread ID). However, each event in the JSON trace profile is expected to include a `tid`, as documented in https://docs.google.com/document/d/1CvAClvFfyA5R-PhYUmn5OOQtYMH4h6I0nSsKchNAySU/preview#heading=h.uxpopqvbjezh This change ensures the counter series events again have a `tid`, using the current thread's ID. This is consistent with the behavior that was present before the refactor. In response to #18548 (comment) Fixes EngFlow/bazel_invocation_analyzer#113 Closes #20300. Commit 16acadb PiperOrigin-RevId: 585636103 Change-Id: I2aa1ff1e656324410d120ff5b6071028b0a5dce3 Co-authored-by: Sara Adams <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The JSON trace profile includes counter for data such as action count, CPU usage, memory usage.
The code for writing the events to include these was refactored in a03674e As part of that change the events written no longer include a
tid(thread ID). However, each event in the JSON trace profile is expected to include atid, as documented inhttps://docs.google.com/document/d/1CvAClvFfyA5R-PhYUmn5OOQtYMH4h6I0nSsKchNAySU/preview#heading=h.uxpopqvbjezh
This change ensures the counter series events again have a
tid, using the current thread's ID. This is consistent with the behavior that was present before the refactor.In response to #18548 (comment)
Fixes EngFlow/bazel_invocation_analyzer#113