Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[7.0.0] Build failures and internal errors when switching from 7.0.0rc3 to 7.0.0rc4 #20278

Merged
merged 1 commit into from
Nov 21, 2023
Merged

[7.0.0] Build failures and internal errors when switching from 7.0.0rc3 to 7.0.0rc4 #20278

merged 1 commit into from
Nov 21, 2023
+125 −25

Commits on Nov 21, 2023

  1. Follow symlinks for getDigest and getFastDigest. 

    The methods are documented as such in FileSystem. If we don't do this, there will be a discrepancy between getFastDigest and stat, as the latter can follow symlinks. This can manifest as a crash (see bazelbuild#20246) as the digest computation will take the missing fast digest for a symlink as a signal to compute the digest manually; this would fail when the symlink target is an in-memory file, which doesn't have an associated inode as required to compute the cache key (see DigestUtils#manuallyComputeDigest).

Fixes bazelbuild#20246.

PiperOrigin-RevId: 584297990
Change-Id: I65e586ea84635a279208e24c421f54ae46ee21b8
    @tjgq @bazel-io
    tjgq authored and bazel-io committed Nov 21, 2023
    Configuration menu
    Copy the full SHA
    e33fb44 View commit details
    Browse the repository at this point in the history