Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Flip the default value of --experimental_remote_discard_merkle_trees to true #19941

Closed
wants to merge 1 commit into from
Closed

Flip the default value of --experimental_remote_discard_merkle_trees to true #19941

wants to merge 1 commit into from

Conversation

moroten
Copy link
Contributor

@moroten moroten commented Oct 25, 2023

No description provided.

@moroten moroten requested a review from a team as a code owner October 25, 2023 12:12
@github-actions github-actions bot added awaiting-review PR is awaiting review from an assigned reviewer team-Remote-Exec Issues and PRs for the Execution (Remote) team labels Oct 25, 2023
@moroten
Copy link
Contributor Author

moroten commented Oct 25, 2023

@EdSchouten here it is!

@EdSchouten
Copy link
Contributor

Then I suppose we should also drop the experimental_ prefix?

@coeuvre
Copy link
Member

coeuvre commented Oct 25, 2023

Thanks! Can you also check why tests are failing?

@coeuvre
Copy link
Member

coeuvre commented Oct 25, 2023 •
edited
Loading

Then I suppose we should also drop the experimental_ prefix?

As we discussed offline, let's keep the prefix because maybe it's possible to restructure the code so that the flag is no longer necessary and can be removed in the future.

@moroten moroten force-pushed the flip-remote-discard-merkle-tree branch from 9a6da11 to 31c121f Compare October 25, 2023 21:39
@moroten
Flip the default value of --remote_discard_merkle_trees to true
85808bd 
This commit also removes the experimental_ prefix.
@moroten moroten force-pushed the flip-remote-discard-merkle-tree branch from 31c121f to 85808bd Compare October 26, 2023 08:26
@coeuvre coeuvre added awaiting-PR-merge PR has been approved by a reviewer and is ready to be merge internally and removed awaiting-review PR is awaiting review from an assigned reviewer labels Oct 26, 2023
@github-actions github-actions bot removed the awaiting-PR-merge PR has been approved by a reviewer and is ready to be merge internally label Oct 26, 2023
@moroten moroten deleted the flip-remote-discard-merkle-tree branch October 26, 2023 19:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@coeuvre coeuvre coeuvre approved these changes

@tjgq tjgq Awaiting requested review from tjgq

Assignees
No one assigned
Labels
team-Remote-Exec Issues and PRs for the Execution (Remote) team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@moroten @EdSchouten @coeuvre