Enable C++ branch coverage when using gcov 8 or later. #18879
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
awaiting-review
c-mita
force-pushed
the
cc_branch_coverage
branch
3 times, most recently
from
33f23ec to
ed9ebda
Compare
|
There's quite a bit of duplication of helper functions in the various coverage related shell tests; I'll have a go at reducing that in a follow up change. |
c-mita
force-pushed
the
cc_branch_coverage
branch
from
ed9ebda to
4280071
Compare
meisterT
reviewed
Jul 11, 2023
| # Extract gcov's version: the output of `gcov --version` contains the | ||
| # version as a set of major-minor-patch numbers, of which we extract | ||
| # the major version. | ||
| gcov_major_version=$("${GCOV}" --version | sed -n -E -e 's/^.*\s([0-9]+)\.[0-9]+\.[0-9]+\s?.*$/\1/p') |
There was a problem hiding this comment.
Why are you using a different mechanism to extract the major version here?
There was a problem hiding this comment.
It's simply replacing what was removed in #18878.
This approach handles using llvm-cov gcov - the tests don't need to worry about that.
There was a problem hiding this comment.
That said, when I come to consolidate things, I'll probably use the same approach everywhere (no reason not to).
But right now, I don't want to change things everywhere in the tests...
Branch coverage was disabled due to a gcov bug, but this was fixed for GCC 8: https://gcc.gnu.org/bugzilla/show_bug.cgi?id=84879. It doesn't make sense to disable all C++ branch coverage for everyone because of a bug in an old GCC version. RELNOTES: Enable C++ branch coverage if gcov version is 8 or newer.
c-mita
force-pushed
the
cc_branch_coverage
branch
from
4280071 to
0cfd753
Compare
meisterT
approved these changes
Jul 11, 2023
github-actions
bot
removed
the
awaiting-review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Branch coverage was disabled due to a gcov bug, but this was fixed for
GCC 8: https://gcc.gnu.org/bugzilla/show_bug.cgi?id=84879.
It doesn't make sense to disable all C++ branch coverage for everyone
because of a bug in an old GCC version.