Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[6.3.0] Fix issue with release notes script #18638

Merged
merged 2 commits into from
Jun 13, 2023
Merged

[6.3.0] Fix issue with release notes script #18638

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
64fdfa8
Fix error when script is run after the final tag is created.
keertk Jun 5, 2023
30e93cb
Merge branch 'release-6.3.0' into 6.3-relnotes-update
iancha1992 Jun 12, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions scripts/release/relnotes.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -171,13 +171,13 @@ def get_external_authors_between(base, head):
is_major = bool(re.fullmatch(r"\d+.0.0", current_release))

tags = [tag for tag in git("tag", "--sort=refname") if "pre" not in tag]

# Get the baseline for RCs (before release tag is created)
if current_release not in tags:
tags.append(current_release)
tags.sort()
last_release = tags[tags.index(current_release) - 1]
else:
print("Error: release tag already exists")
sys.exit(1)

tags.sort()
last_release = tags[tags.index(current_release) - 1]

# Assuming HEAD is on the current (to-be-released) release, find the merge
# base with the last release so that we know which commits to generate notes
Expand Down