Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Flip --incompatible_allow_tags_propagation #18544

Closed
wants to merge 1 commit into from
Closed

Flip --incompatible_allow_tags_propagation #18544

wants to merge 1 commit into from

Conversation

fmeum
Copy link
Collaborator

@fmeum fmeum commented May 31, 2023

Work towards #8830

@fmeum fmeum requested a review from a team as a code owner May 31, 2023 08:39
@fmeum fmeum requested review from sdtwigg and removed request for a team May 31, 2023 08:39
@github-actions github-actions bot added awaiting-review PR is awaiting review from an assigned reviewer team-Configurability platforms, toolchains, cquery, select(), config transitions labels May 31, 2023
@fmeum fmeum mentioned this pull request May 31, 2023
Closed
4 tasks
@fmeum fmeum removed the request for review from sdtwigg May 31, 2023 08:40
@fmeum fmeum requested a review from coeuvre May 31, 2023 13:18
@fmeum
Copy link
Collaborator Author

fmeum commented May 31, 2023

@coeuvre Could you review the flip change, but not merge it yet? The downstream pipeline will run tomorrow morning.

coeuvre
coeuvre reviewed May 31, 2023
View reviewed changes
Copy link
Member

@coeuvre coeuvre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I will mark this as approved after the downstream pipeline is finished.

@fmeum
Copy link
Collaborator Author

fmeum commented Jun 5, 2023

@coeuvre Downstream looks good: https://buildkite.com/bazel/bazelisk-plus-incompatible-flags/builds/1540

@coeuvre
Copy link
Member

coeuvre commented Jun 5, 2023

Nice!

@coeuvre coeuvre added awaiting-PR-merge PR has been approved by a reviewer and is ready to be merge internally and removed awaiting-review PR is awaiting review from an assigned reviewer labels Jun 5, 2023
@fmeum fmeum deleted the 8830-flip branch June 16, 2023 19:29
@sgowroji sgowroji removed the awaiting-PR-merge PR has been approved by a reviewer and is ready to be merge internally label Jun 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@coeuvre coeuvre coeuvre approved these changes

Assignees
No one assigned
Labels
team-Configurability platforms, toolchains, cquery, select(), config transitions
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@fmeum @coeuvre @sgowroji