Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[6.3.0] [credentialhelper] Ignore all errors when writing stdin #18540

Merged
merged 2 commits into from
May 31, 2023
Merged

[6.3.0] [credentialhelper] Ignore all errors when writing stdin #18540

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5f8bb0f
[credentialhelper] Ignore all errors when writing stdin
Yannic May 30, 2023
afd9ba6
Merge branch 'release-6.3.0' into cp18501
iancha1992 May 31, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 2 additions & 6 deletions ...main/java/com/google/devtools/build/lib/authandtls/credentialhelper/CredentialHelper.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,12 +82,8 @@ public GetCredentialsResponse getCredentials(CredentialHelperEnvironment environ
GSON.toJson(GetCredentialsRequest.newBuilder().setUri(uri).build(), stdin);
} catch (IOException e) {
// This can happen if the helper prints a static set of credentials without reading from
// stdin (e.g., with a simple shell script running `echo "{...}"`). If the process is
// already finished even though we failed to write to its stdin, ignore the error and
// assume the process did not need the request payload.
if (!process.finished()) {
throw e;
}
// stdin (e.g., with a simple shell script running `echo "{...}"`). This is fine to
// ignore.
}

try {
Expand Down