Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add dev_dependency to register_{execution_platforms,toolchains} #18253

Closed
wants to merge 1 commit into from
Closed

Add dev_dependency to register_{execution_platforms,toolchains} #18253

wants to merge 1 commit into from

Conversation

fmeum
Copy link
Collaborator

@fmeum fmeum commented Apr 28, 2023

Fixes #18248

@github-actions github-actions bot added awaiting-review PR is awaiting review from an assigned reviewer team-ExternalDeps External dependency handling, remote repositiories, WORKSPACE file. labels Apr 28, 2023
@fmeum
Copy link
Collaborator Author

fmeum commented Apr 28, 2023

@bazel-io flag

@bazel-io bazel-io added the potential release blocker Flagged by community members using "@bazel-io flag". Should be added to a release blocker milestone label Apr 28, 2023
@Wyverald Wyverald modified the milestone: 6.3.0 release blockers Apr 28, 2023
@Wyverald Wyverald added awaiting-PR-merge PR has been approved by a reviewer and is ready to be merge internally and removed awaiting-review PR is awaiting review from an assigned reviewer labels Apr 28, 2023
@Wyverald
Copy link
Member

@bazel-io fork 6.3.0

@bazel-io bazel-io removed the potential release blocker Flagged by community members using "@bazel-io flag". Should be added to a release blocker milestone label Apr 28, 2023
@bazel-io bazel-io mentioned this pull request Apr 28, 2023
Closed
@fmeum fmeum deleted the 18248-dev-dependency branch April 28, 2023 12:43
@keertk keertk mentioned this pull request Apr 28, 2023
Merged
@Pavank1992 Pavank1992 removed the awaiting-PR-merge PR has been approved by a reviewer and is ready to be merge internally label Apr 28, 2023
Wyverald pushed a commit that referenced this pull request Apr 28, 2023
@keertk @fmeum
Add dev_dependency to register_{execution_platforms,toolchains} (#…
286306e 
…18259)

Fixes #18248

Closes #18253.

PiperOrigin-RevId: 527858646
Change-Id: I544694bb55f466bd6e14660ae62f2d535c283563

Co-authored-by: Fabian Meumertzheim <[email protected]>
fweikert pushed a commit to fweikert/bazel that referenced this pull request May 25, 2023
@fmeum @fweikert
Add dev_dependency to register_{execution_platforms,toolchains}
3142d4d 
Fixes bazelbuild#18248

Closes bazelbuild#18253.

PiperOrigin-RevId: 527858646
Change-Id: I544694bb55f466bd6e14660ae62f2d535c283563
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Wyverald Wyverald Wyverald approved these changes

@meteorcloudy meteorcloudy Awaiting requested review from meteorcloudy meteorcloudy is a code owner

Assignees
No one assigned
Labels
team-ExternalDeps External dependency handling, remote repositiories, WORKSPACE file.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Allow dev_dependency register_toolchains calls
4 participants
@fmeum @Wyverald @bazel-io @Pavank1992