Add jsonproto option to query --output flag #18187
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chiragramani
force-pushed
the
query_jsonproto_support
branch
from
78a2ac8
to
6b9d7f4
Compare
github-actions
bot
added
awaiting-review
chiragramani
force-pushed
the
query_jsonproto_support
branch
2 times, most recently
from
a9a67d1
to
76a84f8
Compare
chiragramani
force-pushed
the
query_jsonproto_support
branch
from
76a84f8
to
a80171c
Compare
zhengwei143
requested changes
May 4, 2023
There was a problem hiding this comment.
Thanks for the PR! Could you also add this format to the option's help description (https://github.com/bazelbuild/bazel/blob/master/src/main/java/com/google/devtools/build/lib/query2/query/output/QueryOptions.java#L42-L43)?
zhengwei143
approved these changes
May 9, 2023
bazel-io
added
the
potential release blocker
|
@zhengwei143 Should we cherry pick this into 6.3.0? |
|
No breaking changes here, it just adds a new output option for query. I think it's fine to go ahead with the cherry pick. |
|
@bazel-io fork 6.3.0 |
bazel-io
removed
the
potential release blocker
iancha1992
pushed a commit
to iancha1992/bazel
that referenced
this pull request
May 17, 2023
Addresses bazelbuild#17627 Closes bazelbuild#18187. PiperOrigin-RevId: 530859727 Change-Id: Ie12e6c783448def4b891055647cfe568f7b71b14
iancha1992
added a commit
that referenced
this pull request
May 19, 2023
Addresses #17627 Closes #18187. PiperOrigin-RevId: 530859727 Change-Id: Ie12e6c783448def4b891055647cfe568f7b71b14 Co-authored-by: Chirag Ramani <[email protected]>
fweikert
pushed a commit
to fweikert/bazel
that referenced
this pull request
May 25, 2023
Addresses bazelbuild#17627 Closes bazelbuild#18187. PiperOrigin-RevId: 530859727 Change-Id: Ie12e6c783448def4b891055647cfe568f7b71b14
chiragramani
added a commit
to uber-common/bazel
that referenced
this pull request
Jun 2, 2023
Addresses bazelbuild#17627 Closes bazelbuild#18187. PiperOrigin-RevId: 530859727 Change-Id: Ie12e6c783448def4b891055647cfe568f7b71b14
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #17627