Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add module_ctx.extension_metadata #18174

Merged
merged 2 commits into from
Apr 21, 2023
Merged

Add module_ctx.extension_metadata #18174

merged 2 commits into from
Apr 21, 2023

Commits on Apr 21, 2023

  1. Add module_ctx.extension_metadata 

    Fixes #17908

Closes #17970.

PiperOrigin-RevId: 525134299
Change-Id: I9088e3f4561c0c27135cfdd1e5be8390ea8da7eb
    @fmeum @Wyverald
    fmeum authored and Wyverald committed Apr 21, 2023
    Configuration menu
    Copy the full SHA
    673c8c3 View commit details
    Browse the repository at this point in the history

  2. Canonicalize use_extension label 

    Canonicalize the label by adding the current module's repo_name if the
label doesn't specify a repository name. This is necessary as
ModuleExtensionUsages are grouped by the string value of this label, but
later mapped to their Label representation. If multiple strings map to
the same Label, this would result in a crash.

Also enforce that `module()` is called first (if at all).

Closes #17920.

PiperOrigin-RevId: 520890201
Change-Id: Ice8e2feb0da591e3ba953f4a85284766ba599ebf
    @fmeum @Wyverald
    fmeum authored and Wyverald committed Apr 21, 2023
    Configuration menu
    Copy the full SHA
    fc13f3d View commit details
    Browse the repository at this point in the history