Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change the default for --remote_build_event_upload to minimal #17988

Closed
wants to merge 2 commits into from
Closed

Change the default for --remote_build_event_upload to minimal #17988

wants to merge 2 commits into from

Conversation

brentleyjones
Copy link
Contributor

This also adds tests for --remote_build_event_upload=all.

RELNOTES: Changed the default value for --remote_build_event_upload to minimal.

@brentleyjones
Change the default for --remote_build_event_upload to minimal
1ff956e 
This also adds tests for `--remote_build_event_upload=all`.

RELNOTES: Changed the default value for `--remote_build_event_upload` to `minimal`.
@brentleyjones brentleyjones requested a review from a team as a code owner April 5, 2023 13:51
@github-actions github-actions bot added awaiting-review PR is awaiting review from an assigned reviewer team-Remote-Exec Issues and PRs for the Execution (Remote) team labels Apr 5, 2023
@brentleyjones brentleyjones mentioned this pull request Apr 5, 2023
Closed
@brentleyjones brentleyjones requested a review from coeuvre April 5, 2023 13:52
coeuvre
coeuvre approved these changes Apr 5, 2023
View reviewed changes
Copy link
Member

@coeuvre coeuvre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@coeuvre coeuvre added awaiting-PR-merge PR has been approved by a reviewer and is ready to be merge internally and removed awaiting-review PR is awaiting review from an assigned reviewer labels Apr 5, 2023
@coeuvre
Copy link
Member

coeuvre commented Apr 6, 2023

Hmm, some tests are failing. Maybe we need to explicitly add --remote_build_event_upload=all there.

@brentleyjones
Copy link
Contributor Author

Any context on the delay of this import @kshyanashree?

@sgowroji
Copy link
Member

Hi @brentleyjones, It's internally in progress, will let you know once it is submitted.

@ShreeM01 ShreeM01 removed the awaiting-PR-merge PR has been approved by a reviewer and is ready to be merge internally label Apr 11, 2023
@brentleyjones brentleyjones deleted the bj/change-the-default-for-remote_build_event_upload-to-minimal branch April 11, 2023 18:45
fweikert pushed a commit to fweikert/bazel that referenced this pull request May 25, 2023
@brentleyjones @fweikert
Change the default for --remote_build_event_upload to minimal
a839aef 
This also adds tests for `--remote_build_event_upload=all`.

RELNOTES: Changed the default value for `--remote_build_event_upload` to `minimal`.

Closes bazelbuild#17988.

PiperOrigin-RevId: 523445009
Change-Id: Iaa1f5c3483e7a9512b33e5600dc4fbb4497e814b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@coeuvre coeuvre coeuvre approved these changes

Assignees
No one assigned
Labels
team-Remote-Exec Issues and PRs for the Execution (Remote) team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@brentleyjones @coeuvre @sgowroji @ShreeM01