Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for .tbz file extension in repository_ctx.download_and_extract #17825

Closed

Conversation

benji-sb
Copy link
Contributor

The download_and_extract function supported .tar.bz2 files, but did not recognize .tbz as a valid file extension for those. This commit simply adds support for this, in the code, in the test and in the doc.

Fixes #17824

@google-cla
Copy link

google-cla bot commented Mar 20, 2023

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@sgowroji sgowroji added team-ExternalDeps External dependency handling, remote repositiories, WORKSPACE file. awaiting-review PR is awaiting review from an assigned reviewer awaiting-user-response Awaiting a response from the author and removed awaiting-review PR is awaiting review from an assigned reviewer labels Mar 20, 2023
@sgowroji
Copy link
Member

Hi @Benjamin-SB, Can you please sign the Google CLA. Thanks!

@benji-sb benji-sb force-pushed the support-tbz-file-extension branch 3 times, most recently from 6a139f9 to ba3d741 Compare March 27, 2023 17:04
…tract

The `download_and_extract` function supported `.tar.bz2` files, but did
not recognize `.tbz` as a valid file extension for those. This commit
simply adds support for this, in the code, in the test and in the doc.
@benji-sb benji-sb force-pushed the support-tbz-file-extension branch from ba3d741 to 1d2995e Compare March 27, 2023 17:06
@benji-sb
Copy link
Contributor Author

Hi @sgowroji,

I was told by my company that they signed the CLA, and that my email address is part of the group that is allowed to contribute to Google OSS. However, I'm afraid the cla/google check still doesn't pass.

Is there anything I can do to help for unblocking this?

@Wyverald
Copy link
Member

Did your company just sign the CLA? If so, the process might take a few days.

@benji-sb
Copy link
Contributor Author

Indeed, the CLA check passed as of today. Sorry for the noise!

@sgowroji sgowroji added awaiting-review PR is awaiting review from an assigned reviewer and removed awaiting-user-response Awaiting a response from the author labels Mar 28, 2023
@Wyverald Wyverald added awaiting-PR-merge PR has been approved by a reviewer and is ready to be merge internally and removed awaiting-review PR is awaiting review from an assigned reviewer labels Mar 28, 2023
@sgowroji sgowroji removed the awaiting-PR-merge PR has been approved by a reviewer and is ready to be merge internally label Mar 29, 2023
fweikert pushed a commit to fweikert/bazel that referenced this pull request May 25, 2023
…tract

The `download_and_extract` function supported `.tar.bz2` files, but did not recognize `.tbz` as a valid file extension for those. This commit simply adds support for this, in the code, in the test and in the doc.

Fixes bazelbuild#17824

Closes bazelbuild#17825.

PiperOrigin-RevId: 520049316
Change-Id: Id4a1716304734f58a06cf5dc8d481642f631f5e1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
team-ExternalDeps External dependency handling, remote repositiories, WORKSPACE file.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

download_and_extract function in repository_ctx does not support .tbz file extension
3 participants