-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for .tbz file extension in repository_ctx.download_and_extract #17825
Conversation
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
Hi @Benjamin-SB, Can you please sign the Google CLA. Thanks! |
6a139f9
to
ba3d741
Compare
…tract The `download_and_extract` function supported `.tar.bz2` files, but did not recognize `.tbz` as a valid file extension for those. This commit simply adds support for this, in the code, in the test and in the doc.
ba3d741
to
1d2995e
Compare
Hi @sgowroji, I was told by my company that they signed the CLA, and that my email address is part of the group that is allowed to contribute to Google OSS. However, I'm afraid the cla/google check still doesn't pass. Is there anything I can do to help for unblocking this? |
Did your company just sign the CLA? If so, the process might take a few days. |
Indeed, the CLA check passed as of today. Sorry for the noise! |
…tract The `download_and_extract` function supported `.tar.bz2` files, but did not recognize `.tbz` as a valid file extension for those. This commit simply adds support for this, in the code, in the test and in the doc. Fixes bazelbuild#17824 Closes bazelbuild#17825. PiperOrigin-RevId: 520049316 Change-Id: Id4a1716304734f58a06cf5dc8d481642f631f5e1
The
download_and_extract
function supported.tar.bz2
files, but did not recognize.tbz
as a valid file extension for those. This commit simply adds support for this, in the code, in the test and in the doc.Fixes #17824