Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[6.2.0]python: Remove temporary module space created for zip-based binaries #17764

Merged
merged 2 commits into from
Mar 13, 2023
Merged

[6.2.0]python: Remove temporary module space created for zip-based binaries #17764

merged 2 commits into from
Mar 13, 2023

Commits on Mar 13, 2023

  1. python: Remove temporary module space created for zip-based binaries 

    PR bazelbuild#15590 accidentally introduced a bug where zip-based binaries weren't
cleaning up the temporary runfiles directory they extracted their zip into when
they were run outside of a test invocation.

To fix, explicitly keep track of when the module space needs to be deleted or
not, and pass that long to the code that decides how to execute the program and
how to clean it up afterwards.

Fixes bazelbuild#17342

PiperOrigin-RevId: 513256904
Change-Id: I8c3d322248f734a6290a8a7ee5c8725fae5203dc
    @rickeylev @ShreeM01
    rickeylev authored and ShreeM01 committed Mar 13, 2023
    Configuration menu
    Copy the full SHA
    dc241a0 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'release-6.2.0' into ks/cherry-pick17342

    @ShreeM01
    ShreeM01 authored Mar 13, 2023
    Configuration menu
    Copy the full SHA
    374837e View commit details
    Browse the repository at this point in the history