Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[6.1.1] Fix wasm dynamic library extension crash #17757

Merged
merged 1 commit into from
Mar 13, 2023
Merged

[6.1.1] Fix wasm dynamic library extension crash #17757

merged 1 commit into from
Mar 13, 2023

Commits on Mar 13, 2023

  1. Fix wasm dynamic library extension crash 

    This is an amendment to bazelbuild#17374

We have a C++ toolchain config that's being developed to support standalone wasm. We discovered that bazelbuild#17374 wasn't complete. Our example was poorly written and didn't actually create a wasm dynamic library. These changes allow us to successfully create a standalone wasm dynamic library. Sorry for the botched attempt previously.

I would like to add tests, but I'm unsure how to approach such a tests considering the automatic toolchain doesn't support wasm AFAICT.

Closes bazelbuild#17698.

PiperOrigin-RevId: 516204125
Change-Id: Iced5cc80a3151ffde7116b6264c89eaf40466ff5
    @zaucy @ShreeM01
    zaucy authored and ShreeM01 committed Mar 13, 2023
    Configuration menu
    Copy the full SHA
    5255813 View commit details
    Browse the repository at this point in the history