[remote] upload: treat ALREADY_EXISTS as success
#17692
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the service returns an `ALREADY_EXISTS` error, then we assume that the proper file is present remotely. Prior art: bazelbuild#12112 Fixes bazelbuild#12111
ShreeM01
added
team-Remote-Exec
coeuvre
approved these changes
Mar 9, 2023
coeuvre
added
awaiting-PR-merge
|
@coeuvre Is this safe for 6.2? |
|
@bazel-io fork |
|
@bazel-io flag |
bazel-io
added
the
potential release blocker
sgowroji
removed
the
awaiting-PR-merge
|
@bazel-io fork 6.2.0 |
bazel-io
removed
the
potential release blocker
ShreeM01
pushed a commit
to ShreeM01/bazel
that referenced
this pull request
Mar 10, 2023
If the service returns an `ALREADY_EXISTS` error, then we assume that the proper file is present remotely. Prior art: bazelbuild#12112 Fixes bazelbuild#12111 Closes bazelbuild#17692. PiperOrigin-RevId: 515339566 Change-Id: Iafdd288148e47197cc047d39c9a5e5b6c95acee1
ShreeM01
added a commit
that referenced
this pull request
Mar 13, 2023
If the service returns an `ALREADY_EXISTS` error, then we assume that the proper file is present remotely. Prior art: #12112 Fixes #12111 Closes #17692. PiperOrigin-RevId: 515339566 Change-Id: Iafdd288148e47197cc047d39c9a5e5b6c95acee1 Co-authored-by: Yannic Bonenberger <[email protected]>
fweikert
pushed a commit
to fweikert/bazel
that referenced
this pull request
May 25, 2023
If the service returns an `ALREADY_EXISTS` error, then we assume that the proper file is present remotely. Prior art: bazelbuild#12112 Fixes bazelbuild#12111 Closes bazelbuild#17692. PiperOrigin-RevId: 515339566 Change-Id: Iafdd288148e47197cc047d39c9a5e5b6c95acee1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the service returns an
ALREADY_EXISTSerror, then we assume that the proper file is present remotely.Prior art: #12112
Fixes #12111