Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[6.1.0]Add support for wrapping system streams in WorkRequestHandler #17593

Closed
wants to merge 1 commit into from
Closed

[6.1.0]Add support for wrapping system streams in WorkRequestHandler #17593

wants to merge 1 commit into from

Commits on Feb 24, 2023

  1. Add support for wrapping system streams in WorkRequestHandler 

    There are often [places](https://github.com/bazelbuild/bazel/blob/ea19c17075478092eb77580e6d3825d480126d3a/src/tools/android/java/com/google/devtools/build/android/ResourceProcessorBusyBox.java#L188) where persistent workers need to swap out the standard system streams to avoid tools poisoning the worker communication streams by writing logs/exceptions to it.

This pull request extracts that pattern into an optional WorkerIO wrapper can be used to swap in and out the standard streams without the added boilerplate.

Closes #14201.

PiperOrigin-RevId: 498983983
Change-Id: Iefb956d38a5887d9e5bbf0821551eb0efa14fce9
    @Bencodes @ShreeM01
    Bencodes authored and ShreeM01 committed Feb 24, 2023
    Configuration menu
    Copy the full SHA
    d02ad58 View commit details
    Browse the repository at this point in the history