Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add exec transition to lcov_merger in Java version of py_test #17587

Closed
wants to merge 1 commit into from
Closed

Add exec transition to lcov_merger in Java version of py_test #17587

wants to merge 1 commit into from

Conversation

thirtyseven
Copy link
Contributor

Fixes #17568

@thirtyseven thirtyseven mentioned this pull request Feb 24, 2023
Closed
@thirtyseven thirtyseven changed the title Add host transition to Java version of py_test Add host transition to lcov_merger in Java version of py_test Feb 24, 2023
c-mita
c-mita approved these changes Feb 24, 2023
View reviewed changes
Copy link
Member

@c-mita c-mita left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@thirtyseven
Copy link
Contributor Author

Any chance this can be included in 6.1.0?

@fmeum
Copy link
Collaborator

fmeum commented Feb 24, 2023

@bazel-io flag

@bazel-io bazel-io added the potential release blocker Flagged by community members using "@bazel-io flag". Should be added to a release blocker milestone label Feb 24, 2023
@thirtyseven thirtyseven mentioned this pull request Feb 25, 2023
Merged
@sgowroji sgowroji added the team-Rules-Server Issues for serverside rules included with Bazel label Feb 25, 2023
@keertk
Copy link
Member

keertk commented Feb 26, 2023

@bazel-io fork 6.1.0

@bazel-io bazel-io mentioned this pull request Feb 26, 2023
Closed
@bazel-io bazel-io removed the potential release blocker Flagged by community members using "@bazel-io flag". Should be added to a release blocker milestone label Feb 26, 2023
@keertk keertk added the awaiting-PR-merge PR has been approved by a reviewer and is ready to be merge internally label Feb 26, 2023
@thirtyseven thirtyseven changed the title Add host transition to lcov_merger in Java version of py_test Add exec transition to lcov_merger in Java version of py_test Feb 27, 2023
@sgowroji sgowroji removed the awaiting-PR-merge PR has been approved by a reviewer and is ready to be merge internally label Feb 27, 2023
@thirtyseven thirtyseven mentioned this pull request Mar 1, 2023
Closed
fweikert pushed a commit to fweikert/bazel that referenced this pull request May 25, 2023
@thirtyseven @fweikert
Add host transition to lcov_merger in Java version of py_test
46eae1b 
Fixes bazelbuild#17568

Closes bazelbuild#17587.

PiperOrigin-RevId: 512563828
Change-Id: If95b26f5b86b2848dbaaf6129d1daa1538a22826
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@c-mita c-mita c-mita approved these changes

@comius comius Awaiting requested review from comius comius is a code owner

Assignees
No one assigned
Labels
team-Rules-Server Issues for serverside rules included with Bazel
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Running coverage on a py_test fails when --java_runtime_version is Java 8
6 participants
@thirtyseven @fmeum @keertk @c-mita @bazel-io @sgowroji