Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[6.1.0] Cleanup stale state when remote cache evicted #17538

Merged
merged 2 commits into from
Feb 20, 2023
Merged

[6.1.0] Cleanup stale state when remote cache evicted #17538

merged 2 commits into from
Feb 20, 2023

Commits on Feb 20, 2023

  1. Cleanup stale state when remote cache evicted 

    Currently, when building without the bytes, if Bazel failed to download blobs from CAS when fetching them as inputs to local actions, Bazel fails the build with message like `... --remote_download_outputs=minimal does not work if your remote cache evicts files during builds.` and this message keep showing up until a manually `bazel clean`.

This PR fixes that by cleaning up stale state in skyframe and action cache upon remote cache eviction so that a following build can continue without `bazel shutdown` or `bazel clean`.

Fixes bazelbuild#17366.
Part of bazelbuild#16660.

Closes bazelbuild#17462.

PiperOrigin-RevId: 510952745
Change-Id: I4fc59a21195565c68375a19ead76738d2208c4ac
    @coeuvre
    coeuvre committed Feb 20, 2023
    Configuration menu
    Copy the full SHA
    3164576 View commit details
    Browse the repository at this point in the history

  2. Add integration tests for incremental build for Build without the Bytes. 

    PiperOrigin-RevId: 487193345
Change-Id: Id10c9aebad630928a9a33fa22824e4d78041a4d7
    @coeuvre
    coeuvre committed Feb 20, 2023
    Configuration menu
    Copy the full SHA
    cbe1e6e View commit details
    Browse the repository at this point in the history