-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[docs] Update migrating to Xcode tutorial #17518
Closed
BalestraPatrick
wants to merge
3
commits into
bazelbuild:master
from
BalestraPatrick:update-migrating-to-xcode-tutorial
Closed
[docs] Update migrating to Xcode tutorial #17518
BalestraPatrick
wants to merge
3
commits into
bazelbuild:master
from
BalestraPatrick:update-migrating-to-xcode-tutorial
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BalestraPatrick
requested review from
gregestren and
fweikert
as code owners
February 16, 2023 18:52
brentleyjones
approved these changes
Feb 16, 2023
sgowroji
added
team-Documentation
Documentation improvements that cannot be directly linked to other team labels
awaiting-review
PR is awaiting review from an assigned reviewer
labels
Feb 17, 2023
@fweikert or @gregestren (or whoever needs to approve this), anything we can do to get this merged? I would like to cherry-pick it into 6.1 so the docs website has it for that version. |
I'd just ask for domain approval, which @brentleyjones 's approval qualifies as. |
gregestren
approved these changes
Feb 22, 2023
gregestren
added
awaiting-PR-merge
PR has been approved by a reviewer and is ready to be merge internally
and removed
awaiting-review
PR is awaiting review from an assigned reviewer
labels
Feb 22, 2023
@bazel-io flag |
bazel-io
added
the
potential release blocker
Flagged by community members using "@bazel-io flag". Should be added to a release blocker milestone
label
Feb 22, 2023
sgowroji
removed
the
awaiting-PR-merge
PR has been approved by a reviewer and is ready to be merge internally
label
Feb 23, 2023
brentleyjones
pushed a commit
to brentleyjones/bazel
that referenced
this pull request
Feb 23, 2023
As [Tulsi](https://github.com/bazelbuild/tulsi) has been officially archived, this PR updates the Bazel documentation to replace its mentions in favour of [rules_xcodeproj](https://github.com/buildbuddy-io/rules_xcodeproj). On top of that, this PR also removes the page that shortly documented how to move CocoaPods dependencies in favour of a short paragraph about experimental rules for the Swift Package Manager. Closes bazelbuild#17518. PiperOrigin-RevId: 511749044 Change-Id: I9aa843011525f556fe6ef7260c02cb426aaca6e3 # Conflicts: # site/en/migrate/cocoapods.md
@bazel-io fork 6.1.0 |
bazel-io
removed
the
potential release blocker
Flagged by community members using "@bazel-io flag". Should be added to a release blocker milestone
label
Feb 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
team-Documentation
Documentation improvements that cannot be directly linked to other team labels
team-Rules-ObjC
Issues for Objective-C maintainers
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As Tulsi has been officially archived, this PR updates the Bazel documentation to replace its mentions in favour of rules_xcodeproj. On top of that, this PR also removes the page that shortly documented how to move CocoaPods dependencies in favour of a short paragraph about experimental rules for the Swift Package Manager.