Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs] Update migrating to Xcode tutorial #17518

Conversation

BalestraPatrick
Copy link
Member

As Tulsi has been officially archived, this PR updates the Bazel documentation to replace its mentions in favour of rules_xcodeproj. On top of that, this PR also removes the page that shortly documented how to move CocoaPods dependencies in favour of a short paragraph about experimental rules for the Swift Package Manager.

@sgowroji sgowroji added team-Documentation Documentation improvements that cannot be directly linked to other team labels awaiting-review PR is awaiting review from an assigned reviewer labels Feb 17, 2023
@brentleyjones
Copy link
Contributor

brentleyjones commented Feb 21, 2023

@fweikert or @gregestren (or whoever needs to approve this), anything we can do to get this merged? I would like to cherry-pick it into 6.1 so the docs website has it for that version.

@sgowroji sgowroji added the team-Rules-ObjC Issues for Objective-C maintainers label Feb 22, 2023
@gregestren
Copy link
Contributor

I'd just ask for domain approval, which @brentleyjones 's approval qualifies as.

@gregestren gregestren added awaiting-PR-merge PR has been approved by a reviewer and is ready to be merge internally and removed awaiting-review PR is awaiting review from an assigned reviewer labels Feb 22, 2023
@brentleyjones
Copy link
Contributor

@bazel-io flag

@bazel-io bazel-io added the potential release blocker Flagged by community members using "@bazel-io flag". Should be added to a release blocker milestone label Feb 22, 2023
@sgowroji sgowroji removed the awaiting-PR-merge PR has been approved by a reviewer and is ready to be merge internally label Feb 23, 2023
brentleyjones pushed a commit to brentleyjones/bazel that referenced this pull request Feb 23, 2023
As [Tulsi](https://github.com/bazelbuild/tulsi) has been officially archived, this PR updates the Bazel documentation to replace its mentions in favour of [rules_xcodeproj](https://github.com/buildbuddy-io/rules_xcodeproj). On top of that, this PR also removes the page that shortly documented how to move CocoaPods dependencies in favour of a short paragraph about experimental rules for the Swift Package Manager.

Closes bazelbuild#17518.

PiperOrigin-RevId: 511749044
Change-Id: I9aa843011525f556fe6ef7260c02cb426aaca6e3

# Conflicts:
#	site/en/migrate/cocoapods.md
@ShreeM01
Copy link
Contributor

@bazel-io fork 6.1.0

@bazel-io bazel-io removed the potential release blocker Flagged by community members using "@bazel-io flag". Should be added to a release blocker milestone label Feb 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
team-Documentation Documentation improvements that cannot be directly linked to other team labels team-Rules-ObjC Issues for Objective-C maintainers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants