Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[6.1.0] Only fetch @remote_coverage_tools when collecting coverage #17512

Merged
merged 4 commits into from
Feb 19, 2023

Commits on Feb 16, 2023

  1. Only fetch @remote_coverage_tools when collecting coverage

    Before this change, every test rule had an implicit dependency on `@bazel_tools//tools/test:coverage_report_generator`, even though this tool is only used when collecting coverage.
    
    This is fixed by moving it to `CoverageOptions` and using the late-bound default resolver to only create a dependency if coverage is enabled.
    
    Also adds `CoverageOptions` to the set of options classes trimmed by `--trim_test_configuration` so that, as before, changing `--coverage_report_generator` doesn't cause non-test rules to be reanalyzed. This behavior now extends to `--coverage_output_generator`.
    
    Fixes bazelbuild#15088
    
    Closes bazelbuild#16995.
    
    PiperOrigin-RevId: 498949871
    Change-Id: I2440fae2655bbb701e918ee2aa7acb008d8f97ed
    fmeum committed Feb 16, 2023
    Configuration menu
    Copy the full SHA
    512cfac View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    47a7735 View commit details
    Browse the repository at this point in the history

Commits on Feb 19, 2023

  1. Configuration menu
    Copy the full SHA
    beb0472 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    2bcb038 View commit details
    Browse the repository at this point in the history