Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not recommend shallow_since for git_repository #17356

Closed
wants to merge 1 commit into from

Commits on Jan 30, 2023

  1. Do not recommend shallow_since for git_repository

    Git's `--shallow-since` feature can lead to broken checkouts and a fix
    isn't likely to happen:
    https://public-inbox.org/git/CAPSG9dZV2EPpVKkOMcjv5z+NF7rUu=V-ZkZNx47rCv122HsiKg@mail.gmail.com/T/#u
    
    This commit removes `shallow_since` from the canonical reproducible form
    of `git_repository` unless the attribute is provided explicitly. In
    cases where Bazel's attempt at fetching with `--depth=1` fail, e.g. if
    there is no server support for shallow fetches of arbitrary commits, the
    progress message is now used to inform the user about this potential for
    fetch time optimizations.
    
    Fixes bazelbuild#10292
    Fixes bazelbuild#12857
    fmeum committed Jan 30, 2023
    Configuration menu
    Copy the full SHA
    0dfeda1 View commit details
    Browse the repository at this point in the history