Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle SIGWINCH under bazel run correctly. #17301

Closed
wants to merge 2 commits into from

Conversation

meisterT
Copy link
Member

Previously, after two window resize events we would stop waiting for the child process - this makes sense for other signals but not for SIGWINCH.

Fixes #17215

Previously, after two window resize events we would stop waiting for the
child process - this makes sense for other signals but not for SIGWINCH.

Fixes bazelbuild#17215
@sgowroji sgowroji added team-CLI Console UI awaiting-review PR is awaiting review from an assigned reviewer labels Jan 24, 2023
@copybara-service copybara-service bot closed this in 38ece3c Mar 6, 2023
@brentleyjones
Copy link
Contributor

@meisterT Would this be safe to include in 6.2?

@meisterT
Copy link
Member Author

I think so.

@bazel-io fork

@brentleyjones
Copy link
Contributor

@bazel-io fork 6.2.0

ShreeM01 pushed a commit to ShreeM01/bazel that referenced this pull request Mar 13, 2023
…rectly.

Previously, after two window resize events we would stop waiting for the child process.

`wait` is interrupted by any trapped signal (and we trap all signals), so we need to call it in a loop until the child really exited.

Fixes bazelbuild#17215

Closes bazelbuild#17301.

PiperOrigin-RevId: 514395755
Change-Id: Ifb763a55d53f230cde8b1ca77761d94ea6e43e1f
ShreeM01 added a commit that referenced this pull request Mar 15, 2023
…rectly. (#17760)

Previously, after two window resize events we would stop waiting for the child process.

`wait` is interrupted by any trapped signal (and we trap all signals), so we need to call it in a loop until the child really exited.

Fixes #17215

Closes #17301.

PiperOrigin-RevId: 514395755
Change-Id: Ifb763a55d53f230cde8b1ca77761d94ea6e43e1f

Co-authored-by: Tobias Werth <[email protected]>
fweikert pushed a commit to fweikert/bazel that referenced this pull request May 25, 2023
…rectly.

Previously, after two window resize events we would stop waiting for the child process.

`wait` is interrupted by any trapped signal (and we trap all signals), so we need to call it in a loop until the child really exited.

Fixes bazelbuild#17215

Closes bazelbuild#17301.

PiperOrigin-RevId: 514395755
Change-Id: Ifb763a55d53f230cde8b1ca77761d94ea6e43e1f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaiting-review PR is awaiting review from an assigned reviewer team-CLI Console UI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Resizing the terminal kills bazel run tests
3 participants