Make HttpConnector retries configurable and add jitter #17228
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Wyverald
reviewed
Jan 17, 2023
src/main/java/com/google/devtools/build/lib/bazel/repository/RepositoryOptions.java
Outdated
Show resolved
Hide resolved
src/main/java/com/google/devtools/build/lib/bazel/repository/RepositoryOptions.java
Outdated
Show resolved
Hide resolved
src/main/java/com/google/devtools/build/lib/bazel/repository/RepositoryOptions.java
Outdated
Show resolved
Hide resolved
sgowroji
added
team-ExternalDeps
HttpConnector has some hard coded values for maximum number of attempts and maximum timeout between retries. Make these configurable by command line flags. Also add jitter to those retries.
exoson
force-pushed
the
retry_configuration
branch
from
01ed6a0 to
c06cc18
Compare
Wyverald
approved these changes
Feb 8, 2023
Wyverald
added
awaiting-PR-merge
sgowroji
removed
the
awaiting-PR-merge
hvadehra
pushed a commit
that referenced
this pull request
Feb 14, 2023
HttpConnector has some hard coded values for maximum number of attempts and maximum timeout between retries. Make these configurable by command line flags. Also add jitter to those retries. Closes #17228. PiperOrigin-RevId: 508588893 Change-Id: I345d6000d2131e9a182433fc420440e127e0650e
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
HttpConnector has some hard coded values for maximum number of attempts and maximum timeout between retries. Make these configurable by command line flags. Also add jitter to those retries.