Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Skip empty directories instead of throwing in prefetcher. #17183

Closed
wants to merge 1 commit into from
Closed

Skip empty directories instead of throwing in prefetcher. #17183

wants to merge 1 commit into from

Commits on Jan 10, 2023

  1. Skip empty directories instead of throwing in prefetcher. 

    While non-empty tree artifacts in the inputs to an action are expanded into
the files they contain and omitted from the input mapping, empty tree
artifacts are still present, as they signal the need to create the directory.
Thus, the check added in 763f966 is incorrect.

I'm explicitly skipping the empty tree artifacts in prefetchFiles() as
otherwise they get skipped as a result of FileArtifactValue#isRemote()
returning false for the FileArtifactValue associated with an empty tree
artifact (even if it was produced remotely!), which is extremely subtle.
    @tjgq
    tjgq committed Jan 10, 2023
    Configuration menu
    Copy the full SHA
    1b84172 View commit details
    Browse the repository at this point in the history