-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable compiler_param_file
in Windows MSVC toolchain
#17135
Conversation
@oquenchil The tests fail as they inspect the logs and search for compiler flags. Should I make them look into the |
I was going to suggest that usually the way we do this is to get to the parameter file writing action and look at the flags there instead. Such a test would be easily converted to a Starlark test. But specifically for compiler_param_file there isn't a separate action, so as you are suggesting, we need a strategy that is part of an integration test. Do these compiler flags show up in aquery? If they do, that's probably better than reading the parameter file since it avoids execution. |
Thank you for the very quick PR Fabian. |
509458f
to
199e1b7
Compare
@oquenchil Tests are passing now. I also added a test for long command lines based on your gist. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you Fabian!
Fixes #5163