Do not match java_binary deploy.jar with wildcard target patterns
#17115
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With the native implementation of `java_binary`, `bazel build //...` would not end up building deploy jars. This is achieved for the Starlark implementation by adding the `manual` tag to the deploy jar rule.
fmeum
changed the title
java_binary deploy.jar with wildcard target patternsjava_binary deploy.jar with wildcard target patterns
|
@hvadehra Could you take a look? I noticed this while debugging an unrelated issue at HEAD. |
sgowroji
added
team-Rules-Java
hvadehra
removed
the
awaiting-review
|
Hi @hvadehra, Is the Above PR is Awaiting to merge? |
|
So, this will not work as is, since the tags list could be frozen and we can't append. We'll need to make a copy. I'll going to run a benchmark to ensure the performance penalty isn't too huge. |
hvadehra
pushed a commit
that referenced
this pull request
Feb 14, 2023
With the native implementation of `java_binary`, `bazel build //...` would not end up building deploy jars. This is achieved for the Starlark implementation by adding the `manual` tag to the deploy jar rule. Since the list may already be frozen, we need to make a copy. Closes #17115. PiperOrigin-RevId: 503071603 Change-Id: I99afdac8c040bf0aecd5a1bf7d4acf529058ac22
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the native implementation of
java_binary,bazel build //...would not end up building deploy jars. This is achieved for the Starlark implementation by adding themanualtag to the deploy jar rule.