Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Report AspectCreationException to the user #17071

Closed

Conversation

fmeum
Copy link
Collaborator

@fmeum fmeum commented Dec 23, 2022

Since ec4be00, AspectCreationExceptions are no longer reported to the user, resulting in error messages such as:

ERROR: Analysis of target '//pkg:foo' failed; build aborted:

With this commit, the error looks like this instead:

ERROR: Evaluation of aspect //aspects:aspects.bzl%my_aspect on //pkg:foo failed: <causes...>

Context: bazelbuild/bazel-central-registry#327

@fmeum
Copy link
Collaborator Author

fmeum commented Dec 23, 2022

@meteorcloudy

Since ec4be00,
`AspectCreationException`s were no longer reported to the user,
resulting in error messages such as:

```
ERROR: Analysis of target '//pkg:foo' failed; build aborted:
```

With this commit, the error looks like this instead:

```
ERROR: Evaluation of aspect //aspects:aspects.bzl%my_aspect on //pkg:foo failed: <causes...>
```

Context: bazelbuild/bazel-central-registry#327
@fmeum fmeum force-pushed the report-aspect-creation-exception branch from eabfb2a to d6dce0b Compare December 23, 2022 08:38
Copy link
Member

@meteorcloudy meteorcloudy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!!

@meteorcloudy
Copy link
Member

I guess ideally this should be cherry picked for both 6.x and 5.x (if we make a new minor/patch release)?

@meteorcloudy meteorcloudy added the awaiting-PR-merge PR has been approved by a reviewer and is ready to be merge internally label Dec 23, 2022
@sgowroji sgowroji added the team-OSS Issues for the Bazel OSS team: installation, release processBazel packaging, website label Dec 23, 2022
@fmeum
Copy link
Collaborator Author

fmeum commented Jan 4, 2023

@bazel-io flag

@bazel-io bazel-io added the potential release blocker Flagged by community members using "@bazel-io flag". Should be added to a release blocker milestone label Jan 4, 2023
@sgowroji sgowroji removed the awaiting-PR-merge PR has been approved by a reviewer and is ready to be merge internally label Jan 10, 2023
@fmeum fmeum deleted the report-aspect-creation-exception branch January 10, 2023 07:35
@ShreeM01
Copy link
Contributor

@bazel-io fork 6.1.0

@bazel-io bazel-io removed the potential release blocker Flagged by community members using "@bazel-io flag". Should be added to a release blocker milestone label Jan 19, 2023
meteorcloudy pushed a commit that referenced this pull request Jan 20, 2023
Since ec4be00, `AspectCreationException`s are no longer reported to the user, resulting in error messages such as:

```
ERROR: Analysis of target '//pkg:foo' failed; build aborted:
```

With this commit, the error looks like this instead:

```
ERROR: Evaluation of aspect //aspects:aspects.bzl%my_aspect on //pkg:foo failed: <causes...>
```

Context: bazelbuild/bazel-central-registry#327

Closes #17071.

PiperOrigin-RevId: 500883551
Change-Id: Iaf3b1dff8cb0915dd1ddc51d1d5e6578ff44029b

Co-authored-by: Fabian Meumertzheim <[email protected]>
hvadehra pushed a commit that referenced this pull request Feb 14, 2023
Since ec4be00, `AspectCreationException`s are no longer reported to the user, resulting in error messages such as:

```
ERROR: Analysis of target '//pkg:foo' failed; build aborted:
```

With this commit, the error looks like this instead:

```
ERROR: Evaluation of aspect //aspects:aspects.bzl%my_aspect on //pkg:foo failed: <causes...>
```

Context: bazelbuild/bazel-central-registry#327

Closes #17071.

PiperOrigin-RevId: 500883551
Change-Id: Iaf3b1dff8cb0915dd1ddc51d1d5e6578ff44029b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
team-OSS Issues for the Bazel OSS team: installation, release processBazel packaging, website
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants