Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move BES upload check earlier, to prevent calling FindMissingBlobs #16999

Closed
wants to merge 1 commit into from
Closed

Move BES upload check earlier, to prevent calling FindMissingBlobs #16999

wants to merge 1 commit into from

Commits on Dec 12, 2022

  1. Move BES upload check earlier, to prevent calling FindMissingBlobs 

    Before this change, every file referenced in the BEP would have a `FindMissingBlobs` call, which can be very expensive with hundreds of outputs. This could make `--experimental_remote_build_event_upload=minimal` a performance regression compared to `--experimental_build_event_upload_strategy=local`.
    @brentleyjones
    brentleyjones committed Dec 12, 2022
    Configuration menu
    Copy the full SHA
    7cae483 View commit details
    Browse the repository at this point in the history