Support optional toolchains with find_cpp_toolchain
#16968
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fmeum
force-pushed
the
16966-backwards-compatible-optional-toolchain
branch
from
030ce8e
to
ff81792
Compare
fmeum
commented
Jan 25, 2023
src/main/java/com/google/devtools/build/lib/rules/cpp/CcToolchainAliasRule.java
Outdated
Show resolved
Hide resolved
Rules that want to use optional toolchains but still support builds that don't use C++ toolchain resolution should point their `_cc_toolchain` attribute to the new `@bazel_tools//tools/cpp:optional_current_cc_toolchain` target.
fmeum
force-pushed
the
16966-backwards-compatible-optional-toolchain
branch
from
ff81792
to
8dacbc9
Compare
fmeum
force-pushed
the
16966-backwards-compatible-optional-toolchain
branch
from
8dacbc9
to
74b3c9f
Compare
ShreeM01
added
team-Rules-CPP
oquenchil
approved these changes
Jan 27, 2023
oquenchil
added
awaiting-PR-merge
sgowroji
removed
the
awaiting-PR-merge
hvadehra
pushed a commit
that referenced
this pull request
Feb 14, 2023
Rules that want to use optional toolchains but still support builds that don't use C++ toolchain resolution should point their `_cc_toolchain` attribute to the new `@bazel_tools//tools/cpp:optional_current_cc_toolchain` target. Fixes #16966 Closes #16968. PiperOrigin-RevId: 505707967 Change-Id: I251749348f982ae063b51f7d9cc0078a1b61a948
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rules that want to use optional toolchains but still support builds that don't use C++ toolchain resolution should point their
_cc_toolchainattribute to the new@bazel_tools//tools/cpp:optional_current_cc_toolchaintarget.Fixes #16966