Use xcrun to invoke install_name_tool #16951
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`/usr/bin/install_name_tool` is a shim; it invokes install_name_tool in the current active Xcode. This allows using this template file to configure toolchain on non-macOS. This doesn't change the behavior as both will end up invoking the same tool.
|
Thanks! |
sgowroji
added
team-Rules-CPP
buildbreaker2021
approved these changes
Jan 12, 2023
buildbreaker2021
added
the
awaiting-PR-merge
|
@bazel-io flag |
bazel-io
added
the
potential release blocker
sgowroji
removed
awaiting-review
|
@bazel-io fork 6.1.0 |
bazel-io
removed
the
potential release blocker
ShreeM01
added a commit
that referenced
this pull request
Jan 19, 2023
`/usr/bin/install_name_tool` is a shim; it invokes install_name_tool in the current active Xcode. This allows using this template file to configure toolchain on non-macOS. This doesn't change the behavior as both will end up invoking the same tool. replaces #13462 Closes #16951. PiperOrigin-RevId: 501557408 Change-Id: Ibf0b90aaf18bd703079296248cd66dc6f86359f1 Co-authored-by: Keith Smiley <[email protected]>
hvadehra
pushed a commit
that referenced
this pull request
Feb 14, 2023
`/usr/bin/install_name_tool` is a shim; it invokes install_name_tool in the current active Xcode. This allows using this template file to configure toolchain on non-macOS. This doesn't change the behavior as both will end up invoking the same tool. replaces #13462 Closes #16951. PiperOrigin-RevId: 501557408 Change-Id: Ibf0b90aaf18bd703079296248cd66dc6f86359f1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
/usr/bin/install_name_toolis a shim; it invokes install_name_tool in the current active Xcode.This allows using this template file to configure toolchain on non-macOS. This doesn't change the behavior as both will end up invoking the same tool.
replaces #13462