Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add clarification about how to calculate the MD5 #16848

Closed
wants to merge 1 commit into from

Conversation

rogerhu
Copy link
Contributor

@rogerhu rogerhu commented Nov 25, 2022

I was trying to do echo $PWD | md5sum before stumbling upon this Stack Overflow article - https://stackoverflow.com/a/69816424

@google-cla
Copy link

google-cla bot commented Nov 25, 2022

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@rogerhu
Copy link
Contributor Author

rogerhu commented Nov 25, 2022

The CLA bot seems broken. I have signed and added a GitHub username but rescanning doesn't help. :)

@rogerhu rogerhu closed this Nov 25, 2022
@rogerhu rogerhu reopened this Nov 25, 2022
@rogerhu
Copy link
Contributor Author

rogerhu commented Nov 25, 2022

I've definitely verified my username is added to an existing CLA, as well as the commit maps to the email address tied with the CLA. Something is up with the cla-bot not refreshing?

image

@fmeum
Copy link
Collaborator

fmeum commented Nov 25, 2022

I'm not entirely sure it matters, but did you also sign the CLA for the email used in the commit?

@rogerhu
Copy link
Contributor Author

rogerhu commented Nov 25, 2022

Yep! That's what is so odd about it. My email in the commit matches that of the login (https://cla.developers.google.com/clas). I tried to see if it was a caching bug but the problem still persists.

@rogerhu
Copy link
Contributor Author

rogerhu commented Nov 26, 2022

Adding https://patch-diff.githubusercontent.com/raw/bazelbuild/bazel/pull/16848.patch also shows my gmail address tied to CLA. So something is wrong with the bot?

@sgowroji sgowroji added team-Documentation Documentation improvements that cannot be directly linked to other team labels awaiting-user-response Awaiting a response from the author labels Nov 28, 2022
@sgowroji
Copy link
Member

@rogerhu Can you please sign CLA with the below email used. Thanks!
Screenshot 2022-11-28 at 9 28 06 AM

@rogerhu
Copy link
Contributor Author

rogerhu commented Nov 28, 2022

It's there for me. :) Is the CLA too old to be used?

image

@meteorcloudy
Copy link
Member

@rogerhu I triggered the CLA check again, it seems to work now!

@rogerhu
Copy link
Contributor Author

rogerhu commented Nov 30, 2022

@rogerhu I triggered the CLA check again, it seems to work now!

Thank you!

@sgowroji sgowroji added awaiting-review PR is awaiting review from an assigned reviewer and removed awaiting-user-response Awaiting a response from the author labels Nov 30, 2022
@gregestren gregestren added awaiting-PR-merge PR has been approved by a reviewer and is ready to be merge internally and removed awaiting-review PR is awaiting review from an assigned reviewer labels Nov 30, 2022
@copybara-service copybara-service bot closed this in f65062b Dec 2, 2022
@sgowroji sgowroji removed the awaiting-PR-merge PR has been approved by a reviewer and is ready to be merge internally label Dec 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
team-Documentation Documentation improvements that cannot be directly linked to other team labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants