Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable custom py_binary stub_template attribute (via py_runtime) #16806

Closed
wants to merge 4 commits into from
Closed

Enable custom py_binary stub_template attribute (via py_runtime) #16806

wants to merge 4 commits into from

Commits on Dec 21, 2022

  1. Enable custom py_binary stub_template attribute (via py_runtime) 

    Fixes bazelbuild#137, but unlike my approach in bazelbuild#6632, this adds an attribute to
`py_runtime` rather than to `py_binary`

Open to suggestions on the attribute name and documentation
    @fahhem
    fahhem committed Dec 21, 2022
    Configuration menu
    Copy the full SHA
    c6b5adc View commit details
    Browse the repository at this point in the history

  2. ctx.attr => ctx.file fixes so many things

    @fahhem
    fahhem committed Dec 21, 2022
    Configuration menu
    Copy the full SHA
    8f221ed View commit details
    Browse the repository at this point in the history

  3. rickeylev review: removing unused code and using TOOLS_REPO

    @fahhem
    fahhem committed Dec 21, 2022
    Configuration menu
    Copy the full SHA
    2e4d998 View commit details
    Browse the repository at this point in the history

  4. add back DEFAULT_BOOTSTRAP_TEMPLATE string

    @fahhem
    fahhem committed Dec 21, 2022
    Configuration menu
    Copy the full SHA
    32d6193 View commit details
    Browse the repository at this point in the history