Add -dead_strip in default opt link flags for darwin #16770
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is similar to the `--gc-sections` addition here. `-dead_strip` is supported on all versions of ld64 we care about.
sgowroji
added
team-Rules-CPP
buildbreaker2021
approved these changes
Jan 12, 2023
buildbreaker2021
added
the
awaiting-PR-merge
keith
deleted the
ks/add-dead_strip-in-default-opt-link-flags-for-darwin
branch
|
@bazel-io flag |
bazel-io
added
the
potential release blocker
sgowroji
removed
awaiting-review
|
@bazel-io fork 6.1.0 |
bazel-io
removed
the
potential release blocker
ShreeM01
added a commit
that referenced
this pull request
Jan 27, 2023
This is similar to the `--gc-sections` addition here. `-dead_strip` is supported on all versions of ld64 we care about. Closes #16770. PiperOrigin-RevId: 501557438 Change-Id: Ia5e1e94305361f10f1b20654d83edb76126b3056 Co-authored-by: Keith Smiley <[email protected]>
hvadehra
pushed a commit
that referenced
this pull request
Feb 14, 2023
This is similar to the `--gc-sections` addition here. `-dead_strip` is supported on all versions of ld64 we care about. Closes #16770. PiperOrigin-RevId: 501557438 Change-Id: Ia5e1e94305361f10f1b20654d83edb76126b3056
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is similar to the
--gc-sectionsaddition here.-dead_stripis supported on all versions of ld64 we care about.