Update GetActionResult for disk cache to check referenced files when … #16731
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…building without the bytes
sgowroji
added
team-Remote-Exec
tjgq
approved these changes
Nov 11, 2022
src/main/java/com/google/devtools/build/lib/remote/disk/DiskCacheClient.java
Outdated
Show resolved
Hide resolved
src/main/java/com/google/devtools/build/lib/remote/disk/DiskCacheClient.java
Outdated
Show resolved
Hide resolved
| import static com.google.devtools.build.lib.testutil.TestUtils.tmpDirFile; | ||
|
|
||
| import com.google.common.collect.ImmutableList; | ||
| import com.google.devtools.build.lib.buildtool.util.BuildIntegrationTestCase; |
There was a problem hiding this comment.
It looks like there's a missing BUILD dependency for this?
src/test/java/com/google/devtools/build/lib/remote/DiskCacheIntegrationTest.java
Show resolved
Hide resolved
src/test/java/com/google/devtools/build/lib/remote/DiskCacheIntegrationTest.java
Outdated
Show resolved
Hide resolved
src/test/java/com/google/devtools/build/lib/remote/DiskCacheIntegrationTest.java
Outdated
Show resolved
Hide resolved
src/main/java/com/google/devtools/build/lib/remote/disk/DiskCacheClient.java
Show resolved
Hide resolved
|
@coeuvre Can this get into 6.0? |
|
@bazel-io fork 6.0.0 |
coeuvre
added a commit
to coeuvre/bazel
that referenced
this pull request
Nov 24, 2022
…building without the bytes. Closes bazelbuild#16731. PiperOrigin-RevId: 490262565 Change-Id: I342ec2371b81b9e23fc7935e30d5fed8fb6d4005
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…building without the bytes.