Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Flip --incompatible_always_include_files_in_data #16692

Closed
wants to merge 1 commit into from
Closed

Flip --incompatible_always_include_files_in_data #16692

wants to merge 1 commit into from

Conversation

fmeum
Copy link
Collaborator

@fmeum fmeum commented Nov 8, 2022

RELNOTES[INC]: --incompatible_always_include_files_in_data is flipped to true. See #16654 for details.

Fixes #16654

@fmeum
Flip --incompatible_always_include_files_in_data
b3072b5 
RELNOTES[INC]: `--incompatible_always_include_files_in_data` is flipped
to true. See bazelbuild#16654 for
details.
@fmeum
Copy link
Collaborator Author

fmeum commented Nov 8, 2022

@comius Could you review? The downstream test run passed: https://buildkite.com/bazel/bazelisk-plus-incompatible-flags/builds/1326

@sgowroji sgowroji added team-Rules-Server Issues for serverside rules included with Bazel awaiting-review PR is awaiting review from an assigned reviewer labels Nov 8, 2022
@comius
Copy link
Contributor

comius commented Nov 8, 2022

Let me import this one as I also need to unflip the flag internally.

@comius comius removed the awaiting-review PR is awaiting review from an assigned reviewer label Nov 8, 2022
@comius comius self-assigned this Nov 8, 2022
@fmeum
Copy link
Collaborator Author

fmeum commented Nov 8, 2022

@bazel-io flag

@bazel-io bazel-io added the potential release blocker Flagged by community members using "@bazel-io flag". Should be added to a release blocker milestone label Nov 8, 2022
@meteorcloudy
Copy link
Member

@bazel-io fork 6.0.0

@bazel-io bazel-io removed the potential release blocker Flagged by community members using "@bazel-io flag". Should be added to a release blocker milestone label Nov 18, 2022
@meteorcloudy meteorcloudy added the awaiting-PR-merge PR has been approved by a reviewer and is ready to be merge internally label Nov 18, 2022
@bazel-io bazel-io mentioned this pull request Nov 18, 2022
Closed
@meteorcloudy meteorcloudy mentioned this pull request Nov 18, 2022
Merged
@fmeum fmeum deleted the 16654-flip branch November 30, 2022 21:55
@sgowroji sgowroji removed the awaiting-PR-merge PR has been approved by a reviewer and is ready to be merge internally label Dec 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@comius comius comius approved these changes

Assignees

@comius comius

Labels
team-Rules-Server Issues for serverside rules included with Bazel
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

incompatible_always_include_files_in_data
5 participants
@fmeum @comius @meteorcloudy @bazel-io @sgowroji