Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make C++ runfiles library repo mapping aware #16623

Closed
wants to merge 2 commits into from

Conversation

fmeum
Copy link
Collaborator

@fmeum fmeum commented Nov 1, 2022

Also removes a comment mentioning a Create overload that does not exist.

Work towards #16124

Also removes a comment mentioning a `Create` overload that does not
exist.
@fmeum
Copy link
Collaborator Author

fmeum commented Nov 1, 2022

@oquenchil @Wyverald Could you review?

@sgowroji sgowroji added team-Rules-CPP Issues for C++ rules awaiting-review PR is awaiting review from an assigned reviewer labels Nov 1, 2022
tools/cpp/runfiles/runfiles_src.h Outdated Show resolved Hide resolved
tools/cpp/runfiles/runfiles_src.h Outdated Show resolved Hide resolved
tools/cpp/runfiles/runfiles_src.h Outdated Show resolved Hide resolved
@fmeum fmeum requested a review from Wyverald November 2, 2022 20:46
@fmeum fmeum force-pushed the 16124-cc-repo-mapping branch from d5ee72e to 80074c4 Compare November 2, 2022 20:52
@oquenchil oquenchil added awaiting-PR-merge PR has been approved by a reviewer and is ready to be merge internally and removed awaiting-review PR is awaiting review from an assigned reviewer labels Nov 3, 2022
@Wyverald
Copy link
Member

Wyverald commented Nov 3, 2022

@bazel-io fork 6.0.0

@copybara-service copybara-service bot closed this in 8f28513 Nov 7, 2022
@sgowroji sgowroji removed the awaiting-PR-merge PR has been approved by a reviewer and is ready to be merge internally label Nov 7, 2022
@fmeum fmeum deleted the 16124-cc-repo-mapping branch November 7, 2022 18:00
fmeum added a commit to fmeum/bazel that referenced this pull request Nov 7, 2022
Also removes a comment mentioning a `Create` overload that does not exist.

Work towards bazelbuild#16124

Closes bazelbuild#16623.

PiperOrigin-RevId: 486612245
Change-Id: Ib22cadd354c93eb1e113e27b271c639345c20074
@ShreeM01
Copy link
Contributor

ShreeM01 commented Nov 7, 2022

Hi @fmeum! I am trying to cherry-pick this change to the release-6.0.0 #16675, but pre-submits checks are failing due to missing dependencies. So could you please help us in cherry-picking this change with appropriate commits? Thanks!

@fmeum
Copy link
Collaborator Author

fmeum commented Nov 7, 2022

@kshyanashree I think that the test failure is caused by this Git update. It also fails on master with Git 2.38.1.

@meteorcloudy

@meteorcloudy
Copy link
Member

Yes, we just pushed new docker image for Linux VMs, there seems to be some problem, I have reverted the image version to the last working version, rerun the presubmit should fix the problem.

@ShreeM01
Copy link
Contributor

ShreeM01 commented Nov 7, 2022

@kshyanashree I think that the test failure is caused by this Git update. It also fails on master with Git 2.38.1.

@meteorcloudy

Ohh I see! Thanks for the info @fmeum

@ShreeM01
Copy link
Contributor

ShreeM01 commented Nov 7, 2022

Yes, we just pushed new docker image for Linux VMs, there seems to be some problem, I have reverted the image version to the last working version, rerun the presubmit should fix the problem.

Thanks @meteorcloudy!

ShreeM01 added a commit that referenced this pull request Nov 7, 2022
Also removes a comment mentioning a `Create` overload that does not exist.

Work towards #16124

Closes #16623.

PiperOrigin-RevId: 486612245
Change-Id: Ib22cadd354c93eb1e113e27b271c639345c20074

Co-authored-by: Fabian Meumertzheim <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
team-Rules-CPP Issues for C++ rules
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants