Relax Label repo visibility validation
#16578
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Failing the build eagerly when `Label` is passed a label string referencing an unknown apparent repository name turned out to be too strict and causes failures on invalid, but unused labels: https://buildkite.com/bazel/bazel-bazel-with-bzlmod/builds/667#01841861-3d3a-4b65-91b7-b7083ee6b42b Instead, fail when a method that requires a valid repository name is called on an invalid `Label` instance.
fmeum
force-pushed
the
lazy-label-error
branch
from
7301d9e to
ef08296
Compare
|
@meteorcloudy Could you check that this fixes the Bazel build? |
sgowroji
added
team-OSS
Wyverald
approved these changes
Oct 27, 2022
|
@bazel-io flag |
bazel-io
added
the
potential release blocker
|
Yes, I tested this fixed worked! |
meteorcloudy
added
awaiting-PR-merge
|
@bazel-io fork 6.0.0 |
bazel-io
removed
the
potential release blocker
sgowroji
removed
the
awaiting-PR-merge
fmeum
added a commit
to fmeum/bazel
that referenced
this pull request
Oct 27, 2022
Failing the build eagerly when `Label` is passed a label string referencing an unknown apparent repository name turned out to be too strict and causes failures on invalid, but unused labels: https://buildkite.com/bazel/bazel-bazel-with-bzlmod/builds/667#01841861-3d3a-4b65-91b7-b7083ee6b42b Instead, fail when a method that requires a valid repository name is called on an invalid `Label` instance. Closes bazelbuild#16578. PiperOrigin-RevId: 484232254 Change-Id: Ic64ea5db691f39a20dda47e60e2d6f5436ebca1e
fmeum
added a commit
to fmeum/bazel
that referenced
this pull request
Oct 27, 2022
Failing the build eagerly when `Label` is passed a label string referencing an unknown apparent repository name turned out to be too strict and causes failures on invalid, but unused labels: https://buildkite.com/bazel/bazel-bazel-with-bzlmod/builds/667#01841861-3d3a-4b65-91b7-b7083ee6b42b Instead, fail when a method that requires a valid repository name is called on an invalid `Label` instance. Closes bazelbuild#16578. PiperOrigin-RevId: 484232254 Change-Id: Ic64ea5db691f39a20dda47e60e2d6f5436ebca1e
ShreeM01
added a commit
that referenced
this pull request
Oct 27, 2022
Failing the build eagerly when `Label` is passed a label string referencing an unknown apparent repository name turned out to be too strict and causes failures on invalid, but unused labels: https://buildkite.com/bazel/bazel-bazel-with-bzlmod/builds/667#01841861-3d3a-4b65-91b7-b7083ee6b42b Instead, fail when a method that requires a valid repository name is called on an invalid `Label` instance. Closes #16578. PiperOrigin-RevId: 484232254 Change-Id: Ic64ea5db691f39a20dda47e60e2d6f5436ebca1e Co-authored-by: kshyanashree <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Failing the build eagerly when
Labelis passed a label string referencing an unknown apparent repository name turned out to be too strict and causes failures on invalid, but unused labels: https://buildkite.com/bazel/bazel-bazel-with-bzlmod/builds/667#01841861-3d3a-4b65-91b7-b7083ee6b42bInstead, fail when a method that requires a valid repository name is called on an invalid
Labelinstance.