Use "apparent name" instead of "local name" in Bzlmod docs #16548
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
"Apparent" is used all over the codebase now, so it makes sense to also use it in user-facing docs. Also slightly rewords the definition of an "apparent repository name" to make it easier to understand.
|
@meteorcloudy Could you review? This was the result of a discussion with @Wyverald on #16321 (comment). @fweikert Are cherry-picks the way to get this into the docs versioned for 6.0.0? |
Wyverald
approved these changes
Oct 25, 2022
yes |
|
@bazel-io flag |
bazel-io
added
the
potential release blocker
Wyverald
added
the
awaiting-PR-merge
|
@bazel-io fork 6.0.0 |
bazel-io
removed
the
potential release blocker
sgowroji
added
team-Documentation
fmeum
added a commit
to fmeum/bazel
that referenced
this pull request
Oct 28, 2022
"Apparent" is used all over the codebase now, so it makes sense to also use it in user-facing docs. Also slightly rewords the definition of an "apparent repository name" to make it easier to understand. Closes bazelbuild#16548. PiperOrigin-RevId: 484507525 Change-Id: I8e3af88ddbe5f7b31af47d3ea5a6821ac6e71056
Wyverald
pushed a commit
that referenced
this pull request
Oct 28, 2022
"Apparent" is used all over the codebase now, so it makes sense to also use it in user-facing docs. Also slightly rewords the definition of an "apparent repository name" to make it easier to understand. Closes #16548. PiperOrigin-RevId: 484507525 Change-Id: I8e3af88ddbe5f7b31af47d3ea5a6821ac6e71056
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
"Apparent" is used all over the codebase now, so it makes sense to also use it in user-facing docs.
Also slightly rewords the definition of an "apparent repository name" to make it easier to understand.