Infer CPUs for tvOS and watchOS when on Apple Silicon #16547
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ShreeM01
added
team-Rules-ObjC
|
@bazel-io flag |
bazel-io
added
the
potential release blocker
|
@bazel-io fork 6.0.0 |
bazel-io
removed
the
potential release blocker
ShreeM01
added a commit
that referenced
this pull request
Oct 26, 2022
This PR contains the same logical change as aaae8ce but for watchOS and tvOS. When on Apple Silicon, we should build for the right CPU architecture. This is `sim_arm64` for tvOS and `arm64` for watchOS. On a separate note, I'm not sure if `i386` should be the default architecture for watchOS anymore. I'm happy to change that to `x86_64` to align with all the other platforms if people agree. Closes #16547. PiperOrigin-RevId: 483997916 Change-Id: I67b7f2e2edac5184787f3c3511dc49bb4aeef108 Co-authored-by: Patrick Balestra <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains the same logical change as aaae8ce but for watchOS and tvOS. When on Apple Silicon, we should build for the right CPU architecture. This is
sim_arm64for tvOS andarm64for watchOS.On a separate note, I'm not sure if
i386should be the default architecture for watchOS anymore. I'm happy to change that tox86_64to align with all the other platforms if people agree.