Decanonicalize labels emitted by {a,c,}query if possible #16483
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fmeum
force-pushed
the
decanonicalize-query-output
branch
7 times, most recently
from
cb269bb
to
edc9166
Compare
fmeum
commented
Oct 16, 2022
src/main/java/com/google/devtools/build/lib/cmdline/RepositoryMapping.java
Outdated
Show resolved
Hide resolved
fmeum
force-pushed
the
decanonicalize-query-output
branch
5 times, most recently
from
031673b
to
30b3d98
Compare
fmeum
changed the title
|
Stacked on #16482 and thus in draft state, but otherwise ready for review. |
fmeum
force-pushed
the
decanonicalize-query-output
branch
from
30b3d98
to
b897596
Compare
fmeum
force-pushed
the
decanonicalize-query-output
branch
2 times, most recently
from
37eefc6
to
dba373e
Compare
|
I pushed a commit that updates more formatters. This PR doesn't cover the |
fmeum
force-pushed
the
decanonicalize-query-output
branch
2 times, most recently
from
b4c225c
to
566113c
Compare
fmeum
force-pushed
the
decanonicalize-query-output
branch
from
566113c
to
c341e14
Compare
|
@Wyverald I rebased onto master, this is ready for review now. |
Wyverald
reviewed
Oct 24, 2022
src/main/java/com/google/devtools/build/lib/query2/engine/QueryEnvironment.java
Outdated
Show resolved
Hide resolved
fmeum
force-pushed
the
decanonicalize-query-output
branch
from
c341e14
to
1ab51de
Compare
Wyverald
approved these changes
Oct 24, 2022
|
@bazel-io flag |
bazel-io
added
the
potential release blocker
Uses the newly added `PackageIdentifier#getDisplayForm` to turn labels in the output of query, aquery, and cquery into the most concise representation that allows them to be resolved from the context of the main repository.
fmeum
force-pushed
the
decanonicalize-query-output
branch
from
1ab51de
to
5a0c70a
Compare
sgowroji
added
team-ExternalDeps
|
Hello @Wyverald, As I could see we are good to merge the PR, does it require any further review? Thanks! |
|
@kshyanashree Yes, this is good to merge! |
|
@bazel-io fork 6.0.0 |
bazel-io
removed
the
potential release blocker
fmeum
added a commit
to fmeum/bazel
that referenced
this pull request
Nov 2, 2022
Uses the newly added `PackageIdentifier#getDisplayForm` to turn labels in the output of query, aquery, and cquery into the most concise representation that allows them to be resolved from the context of the main repository. Closes bazelbuild#16483. PiperOrigin-RevId: 485584469 Change-Id: I9037bf128713af75b6741eca42b25e3beeb112f7
ShreeM01
added a commit
that referenced
this pull request
Nov 2, 2022
Uses the newly added `PackageIdentifier#getDisplayForm` to turn labels in the output of query, aquery, and cquery into the most concise representation that allows them to be resolved from the context of the main repository. Closes #16483. PiperOrigin-RevId: 485584469 Change-Id: I9037bf128713af75b6741eca42b25e3beeb112f7 Co-authored-by: kshyanashree <[email protected]>
|
merged in #16638 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uses the newly added
PackageIdentifier#getDisplayFormto turn labelsin the output of query, aquery, and cquery into the most concise
representation that allows them to be resolved from the context of the
main repository.