Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix typos in tests. #16425

Closed
wants to merge 2 commits into from
Closed

Fix typos in tests. #16425

wants to merge 2 commits into from

Conversation

xiaoxq
Copy link
Contributor

@xiaoxq xiaoxq commented Oct 7, 2022

No description provided.

@xiaoxq xiaoxq requested review from a team, oquenchil, ahumesky and ted-xie as code owners October 7, 2022 18:45
@ShreeM01 ShreeM01 added team-Documentation Documentation improvements that cannot be directly linked to other team labels awaiting-user-response Awaiting a response from the author labels Oct 8, 2022
oquenchil
oquenchil approved these changes Oct 10, 2022
View reviewed changes
Copy link
Contributor

@oquenchil oquenchil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@oquenchil oquenchil added awaiting-PR-merge PR has been approved by a reviewer and is ready to be merge internally and removed awaiting-user-response Awaiting a response from the author labels Oct 10, 2022
@sgowroji
Copy link
Member

Hello @xiaoxq, Can you please fix the above buildkite checks. Thanks!

@sgowroji sgowroji added awaiting-review PR is awaiting review from an assigned reviewer awaiting-user-response Awaiting a response from the author and removed awaiting-PR-merge PR has been approved by a reviewer and is ready to be merge internally awaiting-review PR is awaiting review from an assigned reviewer labels Oct 20, 2022
@xiaoxq
Copy link
Contributor Author

xiaoxq commented Oct 20, 2022

Hello @xiaoxq, Can you please fix the above buildkite checks. Thanks!

Done. Thank you! Also rebased to HEAD.

lripoche pushed a commit to lripoche/bazel that referenced this pull request Jun 13, 2023
@xiaoxq
Fix typos in tests.
5ac4c51 
Closes bazelbuild#16425.

PiperOrigin-RevId: 484171015
Change-Id: Ie5a5a29574f5c5d786f385b803cbe3d25e13929c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oquenchil oquenchil oquenchil approved these changes

@ahumesky ahumesky Awaiting requested review from ahumesky ahumesky is a code owner

@ted-xie ted-xie Awaiting requested review from ted-xie ted-xie is a code owner

Assignees
No one assigned
Labels
awaiting-user-response Awaiting a response from the author team-Documentation Documentation improvements that cannot be directly linked to other team labels
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@xiaoxq @sgowroji @oquenchil @ShreeM01