Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix strict deps violation in singlejar build #16424

Closed
wants to merge 1 commit into from

Conversation

fmeum
Copy link
Collaborator

@fmeum fmeum commented Oct 7, 2022

singlejar and hence the NONPREBUILT_TOOLCHAIN_CONFIGURATION did not build with --features=layering_check due to includes being used from indirect dependencies.

Work towards #13944 (comment)

@fmeum fmeum force-pushed the 13944-singlejar-layering branch from b295c1b to 189788b Compare October 7, 2022 16:20
singlejar and hence the `NONPREBUILT_TOOLCHAIN_CONFIGURATION` did not
build with `--features=layering_check` due to includes being used from
indirect dependencies.

Work towards bazelbuild#13944 (comment)
@fmeum fmeum force-pushed the 13944-singlejar-layering branch from 189788b to 19ee514 Compare October 7, 2022 16:31
@fmeum fmeum marked this pull request as ready for review October 7, 2022 16:40
@fmeum
Copy link
Collaborator Author

fmeum commented Oct 7, 2022

@hvadehra Could you review this?

@ShreeM01 ShreeM01 added team-Rules-Java Issues for Java rules awaiting-review PR is awaiting review from an assigned reviewer labels Oct 8, 2022
@comius
Copy link
Contributor

comius commented Oct 17, 2022

cc @oquenchil

@comius comius self-requested a review October 17, 2022 12:44
@comius comius added awaiting-PR-merge PR has been approved by a reviewer and is ready to be merge internally and removed awaiting-review PR is awaiting review from an assigned reviewer labels Oct 17, 2022
@sgowroji sgowroji removed the awaiting-PR-merge PR has been approved by a reviewer and is ready to be merge internally label Oct 18, 2022
@fmeum fmeum deleted the 13944-singlejar-layering branch October 18, 2022 09:58
fmeum added a commit to CodeIntelligenceTesting/jazzer that referenced this pull request Nov 8, 2022
Includes bazelbuild/bazel#16424, which fixes
build failures on macOS with layering check.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
team-Rules-Java Issues for Java rules
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants