fix: corporate logo should not have a grey background #16329
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
All the logos became badly rendered in the switch from bazelbuild/bazel-website to devsite.
From inspecting the DOM, I can see that the problem is coming from this calculated css style
.devsite-landing-row-item-image:not([background]) {
background: var(--devsite-background-4);
}
which I think comes from it being classified as a 'button'.
I don't know if there's a way for me to preview this change however.
sgowroji
added
team-Documentation
|
Acknowledging this PR but I'd like @fweikert 's input. |
|
Unfortunately this change does not fix the images, it simply removes the border of the button. However, I found a solution and will send a CL. |
sgowroji
removed
the
awaiting-review
copybara-service bot
pushed a commit
that referenced
this pull request
Oct 4, 2022
As promised in #16329. PiperOrigin-RevId: 478795749 Change-Id: I96d4bae812f3bf05b12dea600b9218da1c1f645b
|
0e1d3ee did the trick. Thanks for reporting this issue! |
|
Thanks @fweikert ! |
aiuto
pushed a commit
to aiuto/bazel
that referenced
this pull request
Oct 12, 2022
As promised in bazelbuild#16329. PiperOrigin-RevId: 478795749 Change-Id: I96d4bae812f3bf05b12dea600b9218da1c1f645b
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All the logos became badly rendered in the switch from bazelbuild/bazel-website to devsite. From inspecting the DOM, I can see that the problem is coming from this calculated css style
which I think comes from it being classified as a 'button'.
I don't know if there's a way for me to preview this change however. I'm following the same styling as the "Build Concepts" cards on https://bazel.build/start