-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add experimental_remote_cache_key_ignore_stamping
to skip volatile stamping files on compute shared cache key
#16240
Conversation
733b624
to
14bad35
Compare
Hi @bozaro! Could you please fix the build failures? Thanks! |
14bad35
to
3739927
Compare
I don't undestand this test and can't reproduce error locally:
|
Looks like a flake due to a network timeout. You can rerun the tests by amending and force-pushing. |
7458cfa
to
026bb1c
Compare
Rebase to master fixed the tests. |
026bb1c
to
db9dd38
Compare
db9dd38
to
1525844
Compare
…stamping files on compute shared cache key
1525844
to
0514eda
Compare
Rebased to |
I use changes from this PR in patched bazel versions: 5.3.0, 5.3.2, 5.4.0, 6.1.1 (Linux binaries and per-version branches avalialbe here: https://github.com/joomcode/bazel/releases) and it works as expected. |
Closing in favor of |
Replace volatile check by |
I finished migrating to Basel 7.0.0 + #20070 yesterday. We are using this version to build the production version. I am satisfied. Now I see the situation as follows:
|
Changes (enabled by
--experimental_remote_cache_key_ignore_stamping
flag):As result, stamping spaws would execute locally, but with correct remote caching.
Related issues:
volatile-status.txt
content affects the caching key on shared cache #16231