Add tool name for objcopy #16158
Add tool name for objcopy #16158
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
m3rcuriel
force-pushed
the
add_objcopy_action
branch
from
b359011 to
b91c8d0
Compare
m3rcuriel
force-pushed
the
add_objcopy_action
branch
from
b91c8d0 to
c7e7a26
Compare
sgowroji
added
team-Rules-CPP
oquenchil
added
awaiting-PR-merge
sgowroji
removed
the
awaiting-PR-merge
It is not clear to me why this constant is in [src/main/starlark/builtins_bzl/common/cc/action_names.bzl](https://github.com/bazelbuild/bazel/blob/master/src/main/starlark/builtins_bzl/common/cc/action_names.bzl) but not in [tools/build_defs/cc/action_names.bzl](https://github.com/bazelbuild/bazel/blob/master/tools/build_defs/cc/action_names.bzl), but it makes `get_tool_for_action` really annoying. Furthermore, it seems that if we are willing to define `llvm-cov` for everyone we should do the same for `objcopy`. Closes #16158. PiperOrigin-RevId: 503922270 Change-Id: Ic0803de27150bb6da02a9daf5bb0337ba5ccc17c
|
Following up on this, is there a reason we have no action name associated with |
|
Is the question related to: #8438 (comment) ? If it is, it doesn't look like you need the action name in action_names.bzl. |
|
In any case it should be fine to add the action name if you want it for the default toolchain. |
|
I don’t mind if objdump is added |
It is not clear to me why this constant is in src/main/starlark/builtins_bzl/common/cc/action_names.bzl but not in tools/build_defs/cc/action_names.bzl, but it makes
get_tool_for_actionreally annoying.Furthermore, it seems that if we are willing to define
llvm-covfor everyone we should do the same forobjcopy.