Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add references to jdk 17 and 18 for linux-aarch64 #16103

Closed
wants to merge 1 commit into from
Closed

Add references to jdk 17 and 18 for linux-aarch64 #16103

wants to merge 1 commit into from

Conversation

nresare
Copy link
Contributor

@nresare nresare commented Aug 15, 2022

Closes #14937

@nresare
Copy link
Contributor Author

nresare commented Aug 15, 2022

Please note that it would be nice to have these artefacts be mirrored on mirror.bazel.build to lessen the load on the upstream server.

@nresare
Copy link
Contributor Author

nresare commented Aug 15, 2022

I have verified that with these changes, a minimal java project now builds with both --java_language_version=17 and --java_language_version=18 on a linux aarch64 host.

@Franetse7
Copy link

Merci au développeur du logiciel Bazel

@sgowroji sgowroji added team-Rules-Java Issues for Java rules awaiting-user-response Awaiting a response from the author labels Aug 16, 2022
@nresare
Copy link
Contributor Author

nresare commented Aug 17, 2022

The build errors listed seems to be related to the test environment being unable to reach cdn.azul.com. See for example this build log:

Error in download_and_extract: java.io.IOException: Error downloading [...]/zulu17.32.13-ca-jdk17.0.2-linux_aarch64.tar.gz: Unknown host: cdn.azul.com

Getting the artefacts added to mirror.bazel.build would be most welcome :)

@sgowroji
Copy link
Member

sgowroji commented Sep 1, 2022

Hello @nresare, You can file a request for mirror artifacts here. I can help you in providing the updated mirror.bazel.build url. Thanks!

@perezd perezd mentioned this pull request Sep 4, 2022
Closed
@perezd
Copy link
Contributor

perezd commented Sep 4, 2022

I filed the issue for mirroring.

@perezd
Copy link
Contributor

perezd commented Sep 5, 2022

Can someone poke the buildkite tests now? I think the mirror is setup.

@sgowroji
Copy link
Member

sgowroji commented Sep 6, 2022

@nresare, @perezd I rebuild the buildkite, but still it throws the error. Did you get a chance to check this update . Thanks!

@nresare nresare force-pushed the master_linux_aarch64_java_17_18 branch 3 times, most recently from 9ffc83f to e9881fd Compare September 6, 2022 12:52
@nresare nresare force-pushed the master_linux_aarch64_java_17_18 branch from e9881fd to b1fc218 Compare September 6, 2022 14:12
@perezd
Copy link
Contributor

perezd commented Sep 6, 2022

OK what should we do then? Not sure how to proceed here.

@comius comius self-assigned this Sep 7, 2022
@copybara-service copybara-service bot closed this in a380a15 Sep 7, 2022
@perezd
Copy link
Contributor

perezd commented Sep 28, 2022

What release will this be available in?

@sgowroji
Copy link
Member

@perezd, This is available in our next major release. Thanks!

@perezd
Copy link
Contributor

perezd commented Sep 28, 2022

Any reason this can't make it into a point release? It's not a breaking change.

aiuto pushed a commit to aiuto/bazel that referenced this pull request Oct 12, 2022
@nresare @aiuto
Add references to jdk 17 and 18 for linux-aarch64
14dcd91 
Closes bazelbuild#14937

Closes bazelbuild#16103.

PiperOrigin-RevId: 472802039
Change-Id: I4125d542bc52c30c3040939d3ad40b47dd664643
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@comius comius comius approved these changes

Assignees

@comius comius

Labels
awaiting-user-response Awaiting a response from the author team-Rules-Java Issues for Java rules
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

targeting java language level 17 or using a java_runtime_level 17 causes build failures on arm64 linux
5 participants
@nresare @Franetse7 @sgowroji @perezd @comius