[credentialhelper] Add parser for flag syntax #15906
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tjgq
requested changes
Jul 18, 2022
src/main/java/com/google/devtools/build/lib/authandtls/credentialhelper/CredentialHelper.java
Show resolved
Hide resolved
...java/com/google/devtools/build/lib/authandtls/credentialhelper/CredentialHelperProvider.java
Outdated
Show resolved
Hide resolved
src/main/java/com/google/devtools/build/lib/remote/RemoteModule.java
Outdated
Show resolved
Hide resolved
src/test/java/com/google/devtools/build/lib/remote/RemoteModuleTest.java
Outdated
Show resolved
Hide resolved
src/test/java/com/google/devtools/build/lib/remote/RemoteModuleTest.java
Outdated
Show resolved
Hide resolved
src/test/java/com/google/devtools/build/lib/remote/RemoteModuleTest.java
Outdated
Show resolved
Hide resolved
|
PTAL |
tjgq
approved these changes
Jul 18, 2022
|
@bazel-io flag |
bazel-io
added
the
potential release blocker
|
@bazel-io fork 5.3.0 |
bazel-io
removed
the
potential release blocker
sgowroji
added
the
team-Remote-Exec
sgowroji
pushed a commit
to sgowroji/bazel
that referenced
this pull request
Jul 20, 2022
Progress on bazelbuild#15856 Closes bazelbuild#15906. PiperOrigin-RevId: 462095541 Change-Id: I4d31ad2ae185b63f0945119483ffafd3ba121d3d
|
Hey @Yannic, we are trying to Cherry-pick these changes to release-5.3.0. But pre-submit checks are failing due to missing dependencies. So, could you please help us in cherry picking these changes to release-5.3.0? |
aranguyen
pushed a commit
to aranguyen/bazel
that referenced
this pull request
Jul 20, 2022
Progress on bazelbuild#15856 Closes bazelbuild#15906. PiperOrigin-RevId: 462095541 Change-Id: I4d31ad2ae185b63f0945119483ffafd3ba121d3d
aranguyen
pushed a commit
to aranguyen/bazel
that referenced
this pull request
Jul 20, 2022
Progress on bazelbuild#15856 Closes bazelbuild#15906. PiperOrigin-RevId: 462095541 Change-Id: I4d31ad2ae185b63f0945119483ffafd3ba121d3d
|
Hello @Yannic, Thank you for the reply. I see Cherry-pick is still failling Even after #15931 PR is merged in to release -5.3.0. I see some compile errors of libauthandtls-hjar.jar for the above attached cherry picks which are missing. Could you please have a look and guide the necessary. |
sgowroji
pushed a commit
to sgowroji/bazel
that referenced
this pull request
Jul 21, 2022
Progress on bazelbuild#15856 Closes bazelbuild#15906. PiperOrigin-RevId: 462095541 Change-Id: I4d31ad2ae185b63f0945119483ffafd3ba121d3d
Yannic
added a commit
to EngFlow/bazel
that referenced
this pull request
Jul 21, 2022
Follow-up on bazelbuild#15930 due to bazelbuild#15906 Progress on bazelbuild#15856
sgowroji
added a commit
that referenced
this pull request
Jul 22, 2022
* [credentialhelper] Add parser for flag syntax Progress on #15856 Closes #15906. PiperOrigin-RevId: 462095541 Change-Id: I4d31ad2ae185b63f0945119483ffafd3ba121d3d * Updating implements for Converter.Contextless<UnresolvedScopedCredentialHelper> * changes on implements Converter<UnresolvedScopedCredentialHelper> { Co-authored-by: Yannic Bonenberger <[email protected]> Co-authored-by: Chenchu K <[email protected]> Co-authored-by: “Gowroji <[email protected]>
sgowroji
pushed a commit
to sgowroji/bazel
that referenced
this pull request
Jul 22, 2022
Follow-up on bazelbuild#15930 due to bazelbuild#15906 Progress on bazelbuild#15856 Closes bazelbuild#15941. PiperOrigin-RevId: 462580799 Change-Id: Ibac79ed68a0c87a4f34eb9d0729abb1552b44519
ckolli5
added a commit
that referenced
this pull request
Jul 25, 2022
Follow-up on #15930 due to #15906 Progress on #15856 Closes #15941. PiperOrigin-RevId: 462580799 Change-Id: Ibac79ed68a0c87a4f34eb9d0729abb1552b44519 Co-authored-by: Yannic Bonenberger <[email protected]> Co-authored-by: Chenchu K <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Progress on #15856